Issue 84893002: Add chrome://quit to shut down Chrome, including packaged apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 84893002: Add chrome://quit to shut down Chrome, including packaged apps. (Closed)

Created:
7 years ago by Sam McNally

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, marja+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add chrome://quit to shut down Chrome, including packaged apps. Now that packaged apps are not quit when using wrench quit, there is no way to completely shut down Chrome. While this is normally a good thing as apps are intended to be separate from Chrome, for developers and other power users, the ability to completely shut down Chrome can be a useful function. This also blacklists chrome://quit and chrome://restart from being saved to the user's session to prevent quit or restart loops. BUG=317414 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238290

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -1 line)			Patch
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/base_session_service.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/session_service_unittest.cc	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

I don't think we should bother adding this. Power users can always kill chrome if ...

7 years ago (2013-11-25 15:18:21 UTC) #2

Sam McNally

Erik Kay asked for this to be added. Please talk to him about it.

7 years ago (2013-11-27 10:23:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/84893002/80001

7 years ago (2013-12-02 23:59:02 UTC) #5

Message was sent while issue was closed.

Change committed as 238290

Expand Messages | Collapse Messages