Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: ppapi/cpp/private/camera_capabilities_private.h

Issue 848863002: PPAPI: implement GetSupportedPreviewSizes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error on Linux build Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/cpp/private/camera_capabilities_private.h
diff --git a/ppapi/cpp/private/camera_capabilities_private.h b/ppapi/cpp/private/camera_capabilities_private.h
index 5151c759e7759eed7b0e9f3aba4e6e658a2c0dec..368fa6b553bf04a0d809ad530faae56c8b4833ad 100644
--- a/ppapi/cpp/private/camera_capabilities_private.h
+++ b/ppapi/cpp/private/camera_capabilities_private.h
@@ -6,6 +6,8 @@
#ifndef PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_
#define PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_
+#include <vector>
+
#include "ppapi/c/private/ppb_camera_capabilities_private.h"
#include "ppapi/cpp/resource.h"
#include "ppapi/cpp/size.h"
@@ -57,14 +59,14 @@ class CameraCapabilities_Private : public Resource {
///
/// @param[out] A vector of <code>Size</code> corresponding to the
/// supported preview sizes in pixels.
- void GetSupportedPreviewSizes(std::vector<Size>* preview_sizes);
+ void GetSupportedPreviewSizes(std::vector<Size>& preview_sizes);
wuchengli 2015/01/19 14:05:03 Google c++ style guide says output should use poin
Justin Chuang 2015/01/26 15:00:50 Done. Test plugin code needs to be updated, too.
/// GetSupportedJpegSize() returns the supported JPEG sizes for the given
/// <code>CameraCapabilities_Private</code>.
///
/// @param[out] A vector of <code>Size</code> corresponding to the
/// supported JPEG image sizes in pixels.
- void GetSupportedJpegSizes(std::vector<Size>* jpeg_sizes);
+ void GetSupportedJpegSizes(std::vector<Size>& jpeg_sizes);
/// IsCameraCapabilities() determines if the given resource is a
/// <code>CameraCapabilities_Private</code>.
@@ -80,4 +82,3 @@ class CameraCapabilities_Private : public Resource {
} // namespace pp
#endif /* PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_ */
-

Powered by Google App Engine
This is Rietveld 408576698