Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: ppapi/cpp/private/camera_capabilities_private.h

Issue 848863002: PPAPI: implement GetSupportedPreviewSizes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error on Linux build Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* Copyright 2014 The Chromium Authors. All rights reserved. 1 /* Copyright 2014 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. 3 * found in the LICENSE file.
4 */ 4 */
5 5
6 #ifndef PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_ 6 #ifndef PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_
7 #define PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_ 7 #define PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_
8 8
9 #include <vector>
10
9 #include "ppapi/c/private/ppb_camera_capabilities_private.h" 11 #include "ppapi/c/private/ppb_camera_capabilities_private.h"
10 #include "ppapi/cpp/resource.h" 12 #include "ppapi/cpp/resource.h"
11 #include "ppapi/cpp/size.h" 13 #include "ppapi/cpp/size.h"
12 14
13 /// @file 15 /// @file
14 /// This file defines the CameraCapabilities_Private interface for 16 /// This file defines the CameraCapabilities_Private interface for
15 /// establishing an image capture configuration resource within the browser. 17 /// establishing an image capture configuration resource within the browser.
16 namespace pp { 18 namespace pp {
17 19
18 /// The <code>CameraCapabilities_Private</code> interface contains methods for 20 /// The <code>CameraCapabilities_Private</code> interface contains methods for
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 CameraCapabilities_Private(PassRef, PP_Resource resource); 52 CameraCapabilities_Private(PassRef, PP_Resource resource);
51 53
52 // Destructor. 54 // Destructor.
53 ~CameraCapabilities_Private(); 55 ~CameraCapabilities_Private();
54 56
55 /// GetSupportedPreviewSizes() returns the supported preview sizes for the 57 /// GetSupportedPreviewSizes() returns the supported preview sizes for the
56 /// given <code>CameraCapabilities_Private</code>. 58 /// given <code>CameraCapabilities_Private</code>.
57 /// 59 ///
58 /// @param[out] A vector of <code>Size</code> corresponding to the 60 /// @param[out] A vector of <code>Size</code> corresponding to the
59 /// supported preview sizes in pixels. 61 /// supported preview sizes in pixels.
60 void GetSupportedPreviewSizes(std::vector<Size>* preview_sizes); 62 void GetSupportedPreviewSizes(std::vector<Size>& preview_sizes);
wuchengli 2015/01/19 14:05:03 Google c++ style guide says output should use poin
Justin Chuang 2015/01/26 15:00:50 Done. Test plugin code needs to be updated, too.
61 63
62 /// GetSupportedJpegSize() returns the supported JPEG sizes for the given 64 /// GetSupportedJpegSize() returns the supported JPEG sizes for the given
63 /// <code>CameraCapabilities_Private</code>. 65 /// <code>CameraCapabilities_Private</code>.
64 /// 66 ///
65 /// @param[out] A vector of <code>Size</code> corresponding to the 67 /// @param[out] A vector of <code>Size</code> corresponding to the
66 /// supported JPEG image sizes in pixels. 68 /// supported JPEG image sizes in pixels.
67 void GetSupportedJpegSizes(std::vector<Size>* jpeg_sizes); 69 void GetSupportedJpegSizes(std::vector<Size>& jpeg_sizes);
68 70
69 /// IsCameraCapabilities() determines if the given resource is a 71 /// IsCameraCapabilities() determines if the given resource is a
70 /// <code>CameraCapabilities_Private</code>. 72 /// <code>CameraCapabilities_Private</code>.
71 /// 73 ///
72 /// @param[in] resource A <code>Resource</code> corresponding to an image 74 /// @param[in] resource A <code>Resource</code> corresponding to an image
73 /// capture capabilities resource. 75 /// capture capabilities resource.
74 /// 76 ///
75 /// @return true if the given resource is an <code> 77 /// @return true if the given resource is an <code>
76 /// CameraCapabilities_Private</code> resource, otherwise false. 78 /// CameraCapabilities_Private</code> resource, otherwise false.
77 static bool IsCameraCapabilities(const Resource& resource); 79 static bool IsCameraCapabilities(const Resource& resource);
78 }; 80 };
79 81
80 } // namespace pp 82 } // namespace pp
81 83
82 #endif /* PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_ */ 84 #endif /* PPAPI_CPP_PRIVATE_CAMERA_CAPABILITIES_PRIVATE_H_ */
83
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698