Add a --enable-gesture-typing flag. Currently this flag does nothing.

Add a --enable-gesture-typing flag. Currently this flag does nothing.

TEST=VirtualKeyboardBrowserTest.* still runs

Committed: https://crrev.com/37b682b69c1af21d39ae591a431c9ac3e357a32a
Cr-Commit-Position: refs/heads/master@{#312611}

[SteveT, 2015-01-21 16:46:42]

stevet@chromium.org changed reviewers:
+ bshe@chromium.org

[SteveT, 2015-01-21 16:46:42]

PTAL.

[bshe, 2015-01-21 16:53:47]

lgtm with a nit.

https://codereview.chromium.org/848843003/diff/1/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/848843003/diff/1/ui/keyboard/keyboard_util.cc...
ui/keyboard/keyboard_util.cc:169: return false;
Do you mind to clean up this code to:
return
base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableGestureTyping)
?
Same for IsExperimentalInputViewEnabled

[SteveT, 2015-01-21 17:02:31]

Done.

https://codereview.chromium.org/848843003/diff/1/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/848843003/diff/1/ui/keyboard/keyboard_util.cc...
ui/keyboard/keyboard_util.cc:169: return false;
Sure. I was not sure if doing that was going to cause some problem so I didn't
make the change, but if you think it's OK, I'll do that.

[SteveT, 2015-01-21 17:02:35]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-21 17:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/20001

[commit-bot: I haz the power, 2015-01-21 17:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 17:10:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[SteveT, 2015-01-21 17:42:54]

stevet@chromium.org changed reviewers:
+ asvitkine@chromium.org

[SteveT, 2015-01-21 17:42:54]

+Alexei - please look at histograms.xml

[Alexei Svitkine (slow), 2015-01-21 17:51:23]

lgtm

[SteveT, 2015-01-21 17:56:19]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-21 17:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/40001

[commit-bot: I haz the power, 2015-01-21 18:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 18:05:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[SteveT, 2015-01-21 18:28:17]

stevet@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[SteveT, 2015-01-21 18:28:17]

+James for extensions/common/api OWNERS review. PTAL.

[wjmaclean, 2015-01-21 21:10:42]

lgtm :-)

[SteveT, 2015-01-21 23:08:05]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:09:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/40001

[commit-bot: I haz the power, 2015-01-21 23:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:10:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[SteveT, 2015-01-21 23:12:15]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:13:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/40001

[commit-bot: I haz the power, 2015-01-21 23:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:31:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[SteveT, 2015-01-21 23:41:22]

stevet@chromium.org changed reviewers:
+ asargent@chromium.org

[SteveT, 2015-01-21 23:41:22]

Ooops, looks like I needed an extensions/ OWNER to review. +Anthony, please take
a look at extensions/common/api/virtual_keyboard_private.json

Thanks!

[asargent_no_longer_on_chrome, 2015-01-21 23:47:33]

lgtm

[SteveT, 2015-01-21 23:48:44]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/40001

[commit-bot: I haz the power, 2015-01-21 23:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:50:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[SteveT, 2015-01-22 00:03:31]

Hey guys, I keep getting this presubmit error even though I think I have all the
right lg.tms from the right OWNERS.

=== begin cut ===
Missing LGTM from an OWNER for these files:
    extensions/common/api/virtual_keyboard_private.json
=== end cut ===

Does anyone know what I am missing? Thanks!


Steve

[asargent_no_longer_on_chrome, 2015-01-22 00:32:07]

On 2015/01/22 00:03:31, SteveT wrote:
> Hey guys, I keep getting this presubmit error even though I think I have all
the
> right lg.tms from the right OWNERS.
> 
> === begin cut ===
> Missing LGTM from an OWNER for these files:
>     extensions/common/api/virtual_keyboard_private.json
> === end cut ===
> 
> Does anyone know what I am missing? Thanks!
> 
> 
> Steve

That's pretty strange - I'm in extensions/OWNERS so it seems like that should
have been sufficient. If you run 'git cl presubmit' locally, does it give you
the list of suggested reviewers? If not you might also try running 'git cl
presubmit --upload' and see if that does.

[SteveT, 2015-01-22 14:35:54]

The CQ bit was checked by stevet@chromium.org

[commit-bot: I haz the power, 2015-01-22 14:36:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848843003/40001

[commit-bot: I haz the power, 2015-01-22 14:37:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 14:38:34]

Patchset 3 (id:??) landed as
https://crrev.com/37b682b69c1af21d39ae591a431c9ac3e357a32a
Cr-Commit-Position: refs/heads/master@{#312611}

[SteveT, 2015-01-22 14:39:13]

On 2015/01/22 00:32:07, Antony Sargent wrote:
> On 2015/01/22 00:03:31, SteveT wrote:
> > Hey guys, I keep getting this presubmit error even though I think I have all
> the
> > right lg.tms from the right OWNERS.
> > 
> > === begin cut ===
> > Missing LGTM from an OWNER for these files:
> >     extensions/common/api/virtual_keyboard_private.json
> > === end cut ===
> > 
> > Does anyone know what I am missing? Thanks!
> > 
> > 
> > Steve
> 
> That's pretty strange - I'm in extensions/OWNERS so it seems like that should
> have been sufficient. If you run 'git cl presubmit' locally, does it give you
> the list of suggested reviewers? If not you might also try running 'git cl
> presubmit --upload' and see if that does.

FYI
git cl presubmit gave no errors, and neither did git cl presubmit --upload.
Checked the commit box again after that and it committed fine. Thanks!