Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 848823002: Fix a bug in RapporService::LoadSecret (Closed)

Created:
5 years, 11 months ago by Steven Holte
Modified:
5 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in RapporService::LoadSecret Testing for this fix to be added by https://codereview.chromium.org/845863002/ BUG=448269 Committed: https://crrev.com/83fc6907e8de0362881e4bcdafd4a2186a008aee Cr-Commit-Position: refs/heads/master@{#311327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/rappor/rappor_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Steven Holte
On 2015/01/13 04:46:41, Steven Holte wrote: > mailto:holte@chromium.org changed reviewers: > + mailto:asvitkine@chromium.org I'm keeping ...
5 years, 11 months ago (2015-01-13 04:48:20 UTC) #2
Alexei Svitkine (slow)
LGTM, please change the CL description to reference the follow-up CL that's adding tests.
5 years, 11 months ago (2015-01-13 16:44:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848823002/1
5 years, 11 months ago (2015-01-13 20:22:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 21:31:49 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:32:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83fc6907e8de0362881e4bcdafd4a2186a008aee
Cr-Commit-Position: refs/heads/master@{#311327}

Powered by Google App Engine
This is Rietveld 408576698