Fix a bug in RapporService::LoadSecret

components/rappor/rappor_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/rappor/rappor_service.h"
 
 #include "base/base64.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
@@ skipping 192 matching lines @@
   DVLOG(2) << "Selected a new Rappor cohort: " << cohort;
   pref_service_->SetInteger(prefs::kRapporCohortSeed, cohort);
   return cohort;
 }
 
 std::string RapporService::LoadSecret() {
   std::string secret;
   std::string secret_base64 = pref_service_->GetString(prefs::kRapporSecret);
   if (!secret_base64.empty()) {
     bool decoded = base::Base64Decode(secret_base64, &secret);
-    if (decoded && secret_.size() == HmacByteVectorGenerator::kEntropyInputSize)
+    if (decoded && secret.size() == HmacByteVectorGenerator::kEntropyInputSize)
       return secret;
     // If the preference fails to decode, or is the wrong size, it must be
     // corrupt, so continue as though it didn't exist yet and generate a new
     // one.
   }
 
   DVLOG(2) << "Generated a new Rappor secret.";
   secret = HmacByteVectorGenerator::GenerateEntropyInput();
   base::Base64Encode(secret, &secret_base64);
   pref_service_->SetString(prefs::kRapporSecret, secret_base64);
@@ skipping 70 matching lines @@
     DCHECK_EQ(parameters.ToString(), metric->parameters().ToString());
     return metric;
   }
 
   RapporMetric* new_metric = new RapporMetric(metric_name, parameters, cohort_);
   metrics_map_[metric_name] = new_metric;
   return new_metric;
 }
 
 }  // namespace rappor