components/password_manager/content/common/credential_manager_types.cc - Issue 848723002: Credential Manager API: Showing both local and federated logins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_types.cc

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc ('K') | « components/password_manager/content/common/credential_manager_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_types.cc

diff --git a/components/password_manager/content/common/credential_manager_types.cc b/components/password_manager/content/common/credential_manager_types.cc

index afbc7e41aeed7ab3543a79089d62d9ef8091ed65..963362292652c29b454f1fda662005351c7c9cb6 100644

--- a/components/password_manager/content/common/credential_manager_types.cc

+++ b/components/password_manager/content/common/credential_manager_types.cc

@@ -33,15 +33,15 @@ CredentialInfo::CredentialInfo(const blink::WebCredential& credential)

}

-CredentialInfo::CredentialInfo(const autofill::PasswordForm& form)

- : id(form.username_value),

+CredentialInfo::CredentialInfo(const autofill::PasswordForm& form,

+ CredentialType form_type)

+ : type(form_type),

+ id(form.username_value),

name(form.display_name),

avatar(form.avatar_url),

password(form.password_value),

federation(form.federation_url) {

DCHECK(!password.empty() || !federation.is_empty());

- type = password.empty() ? CredentialType::CREDENTIAL_TYPE_FEDERATED

- : CredentialType::CREDENTIAL_TYPE_LOCAL;

}

CredentialInfo::~CredentialInfo() {