Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review, please Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
index ea8fdff19fc47648ecd42557ca454bb5505643b7..6fbb4beef5068a5c280da33a152cc488d7cd6dfc 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
@@ -61,7 +61,9 @@ class TestPasswordManagerClient
ScopedVector<autofill::PasswordForm> federated_entries;
federated_entries.assign(federated_forms.begin(), federated_forms.end());
// TODO(vasilii): Do something clever with |federated_forms|.
vasilii 2015/01/13 18:13:29 TODO is irrelevant
melandory 2015/01/16 12:53:20 Done.
- password_manager::CredentialInfo info(*local_entries[0]);
+ password_manager::CredentialInfo info(
+ *local_entries[0],
+ password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(callback,
info));
return true;
@@ -184,7 +186,8 @@ TEST_F(ContentCredentialManagerDispatcherTest,
TEST_F(ContentCredentialManagerDispatcherTest,
CredentialManagerOnNotifySignedIn) {
- CredentialInfo info(form_);
+ CredentialInfo info(form_,
+ password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
dispatcher()->OnNotifySignedIn(kRequestId, info);
const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedIn::ID;

Powered by Google App Engine
This is Rietveld 408576698