Credential Manager API: Showing both local and federated logins.

components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/content_credential_manager_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
@@ skipping 33 matching lines @@
 
   bool PromptUserToSavePassword(
       scoped_ptr<password_manager::PasswordFormManager> manager) override {
     did_prompt_user_to_save_ = true;
     manager_.reset(manager.release());
     return true;
   }
 
   bool PromptUserToChooseCredentials(
       const std::vector<autofill::PasswordForm*>& local_forms,
       const std::vector<autofill::PasswordForm*>& federated_forms,

[vasilii, 2015/01/13 18:13:28]

We should use ScopedVector here. 
ContentCredentialManagerDispatcher::OnGetPasswordStoreResults contains a memory
leak because of this.

[melandory, 2015/01/15 10:04:30]

Do you mind if I add TODO? I think it's better to separate code changes this
from this CL.

[vasilii, 2015/01/15 12:16:57]

Sure.

       base::Callback<void(const password_manager::CredentialInfo&)>
           callback) override {
     EXPECT_FALSE(local_forms.empty() && federated_forms.empty());

[vasilii, 2015/01/13 18:13:29]

The function crashes if local_forms.empty()

[melandory, 2015/01/16 12:53:20]

Done.

     did_prompt_user_to_choose_ = true;
     ScopedVector<autofill::PasswordForm> local_entries;
     local_entries.assign(local_forms.begin(), local_forms.end());
     ScopedVector<autofill::PasswordForm> federated_entries;
     federated_entries.assign(federated_forms.begin(), federated_forms.end());
     // TODO(vasilii): Do something clever with |federated_forms|.

[vasilii, 2015/01/13 18:13:29]

TODO is irrelevant

[melandory, 2015/01/16 12:53:20]

Done.

-    password_manager::CredentialInfo info(*local_entries[0]);
+    password_manager::CredentialInfo info(
+        *local_entries[0],
+        password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
     base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(callback,
                                                                  info));
     return true;
   }
 
   bool did_prompt_user_to_save() const { return did_prompt_user_to_save_; }
   bool did_prompt_user_to_choose() const { return did_prompt_user_to_choose_; }
 
   password_manager::PasswordFormManager* pending_manager() const {
     return manager_.get();
@@ skipping 102 matching lines @@
 
   const uint32 kMsgID = CredentialManagerMsg_AcknowledgeFailedSignIn::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   process()->sink().ClearMessages();
 }
 
 TEST_F(ContentCredentialManagerDispatcherTest,
        CredentialManagerOnNotifySignedIn) {
-  CredentialInfo info(form_);
+  CredentialInfo info(form_,
+                      password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
   dispatcher()->OnNotifySignedIn(kRequestId, info);
 
   const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedIn::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   process()->sink().ClearMessages();
 
   // Allow the PasswordFormManager to talk to the password store, determine
   // that the form is new, and set it as pending.
@@ skipping 106 matching lines @@
   message = process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   CredentialManagerMsg_SendCredential::Param send_param;
   CredentialManagerMsg_SendCredential::Read(message, &send_param);
   EXPECT_NE(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(send_param).type);
   process()->sink().ClearMessages();
   EXPECT_TRUE(client_->did_prompt_user_to_choose());
 }
 
 }  // namespace password_manager