Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 8486004: Update licensecheck to 2.11.2, which contains upstreamed patches: (Closed)

Created:
9 years, 1 month ago by Paweł Hajdan Jr.
Modified:
8 years, 11 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Update licensecheck to 2.11.2, which contains upstreamed patches: 641497 ">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641497 647524 ">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647524 647526 ">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647526 647527 ">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647527 And also a patch by Adam Langley (agl): http://anonscm.debian.org/gitweb/?p=devscripts/devscripts.git;a=commitdiff;h=917d833db3495bdc1252d3e739e8ef68f5710105 BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M third_party/devscripts/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/devscripts/licensecheck.pl View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/devscripts/licensecheck.pl.orig View 6 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
9 years, 1 month ago (2011-11-16 10:38:36 UTC) #1
Lei Zhang
lgtm
9 years, 1 month ago (2011-11-16 20:59:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/8486004/1
9 years, 1 month ago (2011-11-16 21:06:40 UTC) #3
commit-bot: I haz the power
Change committed as 110366
9 years, 1 month ago (2011-11-16 22:22:13 UTC) #4
M-A Ruel
8 years, 11 months ago (2012-01-10 21:24:47 UTC) #5
FTR, I'd prefer you to not use .orig extension, since it's use by many tools,
especially when patching, merging or rebasing, and it is normally ignored on the
slave.

Powered by Google App Engine
This is Rietveld 408576698