Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 848503002: [GCM] Remove GCMDriver::Purge and GCMClient::CheckOut (Closed)

Created:
5 years, 11 months ago by jianli
Modified:
5 years, 11 months ago
Reviewers:
fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GCM] Remove GCMDriver::Purge and GCMClient::CheckOut These are not longer needed. BUG=447016 TEST=tests updated Committed: https://crrev.com/1956259d453a36d46659e676ac25594c29aa30c7 Cr-Commit-Position: refs/heads/master@{#311096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -95 lines) Patch
M components/gcm_driver/fake_gcm_client.h View 4 chunks +1 line, -11 lines 0 comments Download
M components/gcm_driver/fake_gcm_client.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_client_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/gcm_driver/gcm_client_impl_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 4 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jianli
5 years, 11 months ago (2015-01-10 01:04:51 UTC) #2
fgorski
lgtm
5 years, 11 months ago (2015-01-12 19:16:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848503002/1
5 years, 11 months ago (2015-01-12 19:44:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 20:17:19 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 20:18:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1956259d453a36d46659e676ac25594c29aa30c7
Cr-Commit-Position: refs/heads/master@{#311096}

Powered by Google App Engine
This is Rietveld 408576698