Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 848503002: [GCM] Remove GCMDriver::Purge and GCMClient::CheckOut (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index ccbf50be7cf63bb0413f9c2807ea0b260cb8221f..2c15ef28d14250052a60a7d7bcbfc6500507d81b 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -70,7 +70,6 @@ class GCMDriverDesktop::IOWorker : public GCMClient::Delegate {
const scoped_refptr<base::SequencedTaskRunner> blocking_task_runner);
void Start(const base::WeakPtr<GCMDriverDesktop>& service);
void Stop();
- void CheckOut();
void Register(const std::string& app_id,
const std::vector<std::string>& sender_ids);
void Unregister(const std::string& app_id);
@@ -253,15 +252,6 @@ void GCMDriverDesktop::IOWorker::Stop() {
gcm_client_->Stop();
}
-void GCMDriverDesktop::IOWorker::CheckOut() {
- DCHECK(io_thread_->RunsTasksOnCurrentThread());
-
- gcm_client_->CheckOut();
-
- // Note that we still need to keep GCMClient instance alive since the
- // GCMDriverDesktop may check in again.
-}
-
void GCMDriverDesktop::IOWorker::Register(
const std::string& app_id,
const std::vector<std::string>& sender_ids) {
@@ -431,16 +421,6 @@ void GCMDriverDesktop::OnSignedOut() {
signed_in_ = false;
}
-void GCMDriverDesktop::Purge() {
- DCHECK(ui_thread_->RunsTasksOnCurrentThread());
-
- RemoveCachedData();
-
- io_thread_->PostTask(FROM_HERE,
- base::Bind(&GCMDriverDesktop::IOWorker::CheckOut,
- base::Unretained(io_worker_.get())));
-}
-
void GCMDriverDesktop::AddAppHandler(const std::string& app_id,
GCMAppHandler* handler) {
DCHECK(ui_thread_->RunsTasksOnCurrentThread());
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698