Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 848493003: Don't scope check in SelectorChecker. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't scope check in SelectorChecker. Instead of checking if the rule is from the right scope in SelectorChecker, just store :host rules separately and always assume rules are in the right scope in the checker. This removes a lot of complexity that was passing around the scope and checking it, and also the need to plumb if we're matching UA rules down into the checker. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c8184b7e0af33ff4b8c0113aeda23e1e3b6fdf52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -86 lines) Patch
M sky/engine/core/css/ElementRuleCollector.h View 3 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.cpp View 6 chunks +8 lines, -15 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 2 chunks +4 lines, -1 line 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.h View 2 chunks +3 lines, -11 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 5 chunks +12 lines, -30 lines 0 comments Download
M sky/engine/core/css/resolver/MatchRequest.h View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/dom/SelectorQuery.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/html/HTMLContentElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
5 years, 11 months ago (2015-01-10 02:52:47 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-10 02:58:53 UTC) #2
esprehn
5 years, 11 months ago (2015-01-10 03:00:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8184b7e0af33ff4b8c0113aeda23e1e3b6fdf52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698