Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: sky/engine/core/css/SelectorChecker.h

Issue 848493003: Don't scope check in SelectorChecker. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/RuleSet.cpp ('k') | sky/engine/core/css/SelectorChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/SelectorChecker.h
diff --git a/sky/engine/core/css/SelectorChecker.h b/sky/engine/core/css/SelectorChecker.h
index 004d03b42d39a62314175de0ce042cd775f47bf9..2e89aa46da8aa8427759b1095bca5d28116d8730 100644
--- a/sky/engine/core/css/SelectorChecker.h
+++ b/sky/engine/core/css/SelectorChecker.h
@@ -41,19 +41,16 @@ class SelectorChecker {
public:
explicit SelectorChecker(const Element&);
- // TODO(esprehn): scope should never be null.
- bool match(const CSSSelector&, const ContainerNode* scope);
+ bool match(const CSSSelector&);
bool matchedAttributeSelector() const { return m_matchedAttributeSelector; }
bool matchedFocusSelector() const { return m_matchedFocusSelector; }
bool matchedHoverSelector() const { return m_matchedHoverSelector; }
bool matchedActiveSelector() const { return m_matchedActiveSelector; }
- static bool isHostInItsShadowTree(const Element&, const ContainerNode* scope);
-
private:
- bool checkPseudoClass(const CSSSelector&, const ContainerNode* scope);
- bool checkOne(const CSSSelector&, const ContainerNode* scope);
+ bool checkPseudoClass(const CSSSelector&);
+ bool checkOne(const CSSSelector&);
const Element& m_element;
bool m_matchedAttributeSelector;
@@ -62,11 +59,6 @@ private:
bool m_matchedActiveSelector;
};
-inline bool SelectorChecker::isHostInItsShadowTree(const Element& element, const ContainerNode* scope)
-{
- return scope && scope->isInShadowTree() && scope->shadowHost() == element;
-}
-
}
#endif // SKY_ENGINE_CORE_CSS_SELECTORCHECKER_H_
« no previous file with comments | « sky/engine/core/css/RuleSet.cpp ('k') | sky/engine/core/css/SelectorChecker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698