chrome/test/chromedriver/element_util.h - Issue 848483002: [chromedriver] Use center of first ClientRect when moving mouse to an element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/element_util.h

Issue 848483002: [chromedriver] Use center of first ClientRect when moving mouse to an element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add some extra checks to testMoveToElementAndClick Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/element_util.h

diff --git a/chrome/test/chromedriver/element_util.h b/chrome/test/chromedriver/element_util.h

index 0fbd766179b2d9c1689e76d5d7478fcb1577936c..142fd646c7801a11b24b556ee5d0c3436fcf54ab 100644

--- a/chrome/test/chromedriver/element_util.h

+++ b/chrome/test/chromedriver/element_util.h

@@ -131,6 +131,7 @@ Status ScrollElementIntoView(

Session* session,

WebView* web_view,

const std::string& element_id,

+ const WebPoint* offset,

WebPoint* location);

// |element_id| refers to the element which is to be scrolled into view.

« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | chrome/test/chromedriver/element_util.cc » ('J')