chrome/test/chromedriver/element_commands.cc - Issue 848483002: [chromedriver] Use center of first ClientRect when moving mouse to an element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 848483002: [chromedriver] Use center of first ClientRect when moving mouse to an element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add some extra checks to testMoveToElementAndClick Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/element_commands.cc

diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc

index f6907343ef83a6bbde96407bb325fc73ab2b28d0..3eb07a2b8979e0f6ce6fc2b7b1289ee5741ba1fc 100644

--- a/chrome/test/chromedriver/element_commands.cc

+++ b/chrome/test/chromedriver/element_commands.cc

@@ -445,7 +445,7 @@ Status ExecuteGetElementLocationOnceScrolledIntoView(

scoped_ptr<base::Value>* value) {

WebPoint location;

Status status = ScrollElementIntoView(

- session, web_view, element_id, &location);

+ session, web_view, element_id, nullptr, &location);

if (status.IsError())

return status;

value->reset(CreateValueFrom(location));

« no previous file with comments | « no previous file | chrome/test/chromedriver/element_util.h » ('j') | chrome/test/chromedriver/element_util.cc » ('J')