Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 848453003: Ipclist fixes. (Closed)

Created:
5 years, 11 months ago by inferno
Modified:
5 years, 11 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ipclist fixes. 1. Make it work with Windows. 2. Remove non-existent messages. 3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h. R=gunsch@chromium.org, tsepez@chromium.org TBR=ttuttle@chromium.org BUG=450268 Committed: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b Committed: https://chromium.googlesource.com/chromium/src/+/25d61fca28d2ca5b7d469e83251655398df09f42

Patch Set 1 #

Patch Set 2 : Add missing DEPS entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M chromecast/common/media/cma_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_start.h View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/ipclist/ipclist.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/all_messages.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 36 (15 generated)
Tom Sepez
lgtm
5 years, 11 months ago (2015-01-20 21:41:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/1
5 years, 11 months ago (2015-01-20 21:46:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37130) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 21:55:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-20 22:01:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37137) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 22:09:34 UTC) #9
gunsch
chromecast lgtm
5 years, 11 months ago (2015-01-20 22:14:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-20 22:41:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37137)
5 years, 11 months ago (2015-01-20 22:42:44 UTC) #16
inferno
On 2015/01/20 22:42:44, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 22:46:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-20 22:51:39 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25108)
5 years, 11 months ago (2015-01-20 23:58:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-21 01:21:27 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25108)
5 years, 11 months ago (2015-01-21 01:22:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-21 02:50:02 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112741) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96679)
5 years, 11 months ago (2015-01-21 05:11:09 UTC) #29
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/faf8b453fa03869b3109258702ca7cf7b8157f5b Cr-Commit-Position: refs/heads/master@{#312315}
5 years, 11 months ago (2015-01-21 11:27:47 UTC) #30
inferno
Committed patchset #2 (id:20001) manually as faf8b453fa03869b3109258702ca7cf7b8157f5b (tree was closed).
5 years, 11 months ago (2015-01-21 11:27:57 UTC) #31
Nico
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/864873003/ by thakis@chromium.org. ...
5 years, 11 months ago (2015-01-21 21:14:12 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
5 years, 11 months ago (2015-01-21 21:22:06 UTC) #34
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/25d61fca28d2ca5b7d469e83251655398df09f42 Cr-Commit-Position: refs/heads/master@{#312466}
5 years, 11 months ago (2015-01-21 22:00:38 UTC) #35
inferno
5 years, 11 months ago (2015-01-21 22:00:44 UTC) #36
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25d61fca28d2ca5b7d469e83251655398df09f42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698