|
|
Created:
5 years, 11 months ago by inferno Modified:
5 years, 11 months ago CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIpclist fixes.
1. Make it work with Windows.
2. Remove non-existent messages.
3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h.
R=gunsch@chromium.org, tsepez@chromium.org
TBR=ttuttle@chromium.org
BUG=450268
Committed: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b
Committed: https://chromium.googlesource.com/chromium/src/+/25d61fca28d2ca5b7d469e83251655398df09f42
Patch Set 1 #Patch Set 2 : Add missing DEPS entry #
Messages
Total messages: 36 (15 generated)
lgtm
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
gunsch@chromium.org changed reviewers: + gunsch@chromium.org
chromecast lgtm
inferno@chromium.org changed reviewers: + jar@chromium.org, ttuttle@chromium.org
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2015/01/20 22:42:44, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux > (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ttuttle, jar: can you please review the tools/ipc_fuzzer/message_lib/DEPS change, thanks!
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/faf8b453fa03869b3109258702ca7cf7b8157f5b Cr-Commit-Position: refs/heads/master@{#312315}
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as faf8b453fa03869b3109258702ca7cf7b8157f5b (tree was closed).
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/864873003/ by thakis@chromium.org. The reason for reverting is: The review doesn't show it, but this added back third_party/libc++(abi) for some reason: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca... This was moved elsewhere in https://codereview.chromium.org/788063003 and it being back causes all kinds of things, for example me being unable to run `git cl upload`. Please reland this without adding back libc++..
The CQ bit was checked by inferno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848453003/20001
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/25d61fca28d2ca5b7d469e83251655398df09f42 Cr-Commit-Position: refs/heads/master@{#312466}
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25d61fca28d2ca5b7d469e83251655398df09f42 (presubmit successful). |