Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 848443004: Adds QUIC_VERSION_24 which uses SPDY/4 header compression instead of SPDY/3. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0114
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds QUIC_VERSION_24 which uses SPDY/4 header compression instead of SPDY/3. As with other version which change the format of stream frame payloads (in this case just the payloads of headers streams) version negotiation + 0-RTT requests does not work. A client needs to take care never to negotiate across the version boundary. Chrome only ever supports 1 version, so this is not a problem. But some test clients might. (Though they are unlikely to actually do 0-RTT, I think) Merge internal change: 83636915

Patch Set 1 #

Patch Set 2 : Changes to make version 24 to work with chromium unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -87 lines) Patch
M net/quic/quic_headers_stream.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 1 10 chunks +69 lines, -21 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 9 chunks +96 lines, -29 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 3 chunks +28 lines, -13 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +32 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
ramant (doing other things)
https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_stream.cc File net/quic/quic_http_stream.cc (right): https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_stream.cc#newcode118 net/quic/quic_http_stream.cc:118: CreateSpdyHeadersFromHttpRequest( this is wrong. will undo this change https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_stream.cc#newcode521 ...
5 years, 11 months ago (2015-01-16 14:50:02 UTC) #2
ramant (doing other things)
5 years, 11 months ago (2015-01-16 18:24:27 UTC) #5 
On 2015/01/16 14:50:02, ramant wrote:
>
https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_strea...
> File net/quic/quic_http_stream.cc (right):
> 
>
https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_strea...
> net/quic/quic_http_stream.cc:118: CreateSpdyHeadersFromHttpRequest(
> this is wrong. will undo this change
> 
>
https://codereview.chromium.org/848443004/diff/40001/net/quic/quic_http_strea...
> net/quic/quic_http_stream.cc:521: SpdyFramer framer(protocol_version);
> this is wrong. will undo this change

Hi Ryan,
  Ignore the above message. I had undid my changes to quic_http_stream.cc.

  Will wait for your internal changes quic_headers_stream.cc and will merge that
change into this CL.

thanks
raman

Powered by Google App Engine
This is Rietveld 408576698