net/quic/quic_session_test.cc - Issue 848443004: Adds QUIC_VERSION_24 which uses SPDY/4 header compression instead of SPDY/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session_test.cc

Issue 848443004: Adds QUIC_VERSION_24 which uses SPDY/4 header compression instead of SPDY/3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0114

Patch Set: Changes to make version 24 to work with chromium unittests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_session_test.cc

diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc

index 96d30b8c5819228d29c5773b63b79c9e93ddeb46..08d2627b98735a95a5a4413bd3510a18f167ea16 100644

--- a/net/quic/quic_session_test.cc

+++ b/net/quic/quic_session_test.cc

@@ -316,6 +316,10 @@ TEST_P(QuicSessionTest, StreamIdTooLarge) {

TEST_P(QuicSessionTest, DecompressionError) {

QuicHeadersStream* stream = QuicSessionPeer::GetHeadersStream(&session_);

+ if (version() > QUIC_VERSION_23) {

+ // This test does not apply to HPACK compression.

+ return;

+ }

const unsigned char data[] = {

0x80, 0x03, 0x00, 0x01, // SPDY/3 SYN_STREAM frame

0x00, 0x00, 0x00, 0x25, // flags/length

« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/test_tools/quic_test_packet_maker.cc » ('j') | no next file with comments »