Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 848223003: [IME] Use proper const in ImeAdaptor for autocomplete, updating tests. (Closed)

Created:
5 years, 11 months ago by huangs
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IME] Use proper const in ImeAdaptor for autocomplete, updating tests. This is a follow-up clean up to https://chromiumcodereview.appspot.com/842493004/ so we can: - Use the appropriate constant to detect autocomplete="off". - Add test case for autocomplete="off" (returns key code rather than 229). Committed: https://crrev.com/4909fb1cac2676ed87044587a369530f6062e957 Cr-Commit-Position: refs/heads/master@{#311773}

Patch Set 1 #

Patch Set 2 : Put back import java.lang.CharSequence (presubmit was wrong). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
huangs
The follow-up cleanup, as mentioned yesterday.
5 years, 11 months ago (2015-01-14 22:26:03 UTC) #2
huangs
PTAL.
5 years, 11 months ago (2015-01-15 00:06:01 UTC) #3
bcwhite
lgtm
5 years, 11 months ago (2015-01-15 15:13:12 UTC) #4
huangs
Thanks. Submitting!
5 years, 11 months ago (2015-01-15 16:40:46 UTC) #5
huangs
Oh wait need OWNER review. :)
5 years, 11 months ago (2015-01-15 16:41:04 UTC) #6
huangs
OWNER review for aurimas@, PTAL.
5 years, 11 months ago (2015-01-15 16:45:17 UTC) #8
aurimas (slooooooooow)
lgtm
5 years, 11 months ago (2015-01-15 21:18:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848223003/20001
5 years, 11 months ago (2015-01-15 21:42:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:30:40 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:32:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4909fb1cac2676ed87044587a369530f6062e957
Cr-Commit-Position: refs/heads/master@{#311773}

Powered by Google App Engine
This is Rietveld 408576698