Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 848223003: [IME] Use proper const in ImeAdaptor for autocomplete, updating tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put back import java.lang.CharSequence (presubmit was wrong). Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index c955ac358cd3284de50d212ebf8d86a3962ee86c..6f49bb42dfd5e18b052474c079a764efb28acbb3 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -426,13 +426,9 @@ public class ImeAdapter {
KeyEvent.changeAction(keyEvent, KeyEvent.ACTION_UP), 0);
}
- // FIXME: Use WebTextInputFlags.AutocompleteOff. We need this hack to enable merge into
- // into Beta to fix http://crbug.com/422685 .
- final int textInputFlagAutocompleteOff = 1 << 1;
-
// If we do not have autocomplete=off, then always send compose events rather than a
// guessed keyCode. This addresses http://crbug.com/422685 .
- if ((mTextInputFlags & textInputFlagAutocompleteOff) == 0) {
+ if ((mTextInputFlags & WebTextInputFlags.AutocompleteOff) == 0) {
keyCode = COMPOSITION_KEY_CODE;
modifiers = 0;
}
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698