Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 848173002: Remove support for signatures with arguments (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove support for signatures with arguments Support for it is slow and difficult to implement, and it's not used in Blink. An embedder that uses this feature will have to check the argument types itself. BUG=none R=dcarney@chromium.org LOG=y Committed: https://crrev.com/c65799e7c509bd21ce8e2817827ddf51d71e8c94 Cr-Commit-Position: refs/heads/master@{#26058}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -92 lines) Patch
M include/v8.h View 1 chunk +9 lines, -7 lines 0 comments Download
M src/api.cc View 1 2 chunks +17 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-14 13:54:25 UTC) #1
dcarney
lgtm https://codereview.chromium.org/848173002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/848173002/diff/1/src/api.cc#newcode859 src/api.cc:859: i::Handle<i::SignatureInfo> obj = need a TODO to convert ...
5 years, 11 months ago (2015-01-14 14:09:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848173002/20001
5 years, 11 months ago (2015-01-14 14:17:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 14:44:05 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 14:44:18 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c65799e7c509bd21ce8e2817827ddf51d71e8c94
Cr-Commit-Position: refs/heads/master@{#26058}

Powered by Google App Engine
This is Rietveld 408576698