Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: include/v8.h

Issue 848173002: Remove support for signatures with arguments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index e3d52548cc7d3854981fffe805d8c35045b46dce..ca19e05be9789284aac1f5743cda6c8282b71749 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4099,16 +4099,18 @@ class V8_EXPORT ObjectTemplate : public Template {
/**
- * A Signature specifies which receivers and arguments are valid
- * parameters to a function.
+ * A Signature specifies which receiver is valid for a function.
*/
class V8_EXPORT Signature : public Data {
public:
- static Local<Signature> New(Isolate* isolate,
- Handle<FunctionTemplate> receiver =
- Handle<FunctionTemplate>(),
- int argc = 0,
- Handle<FunctionTemplate> argv[] = 0);
+ V8_DEPRECATED("An embedder needs to check the arguments itself",
+ static Local<Signature> New(
+ Isolate* isolate, Handle<FunctionTemplate> receiver,
+ int argc, Handle<FunctionTemplate> argv[] = 0));
+
+ static Local<Signature> New(
+ Isolate* isolate,
+ Handle<FunctionTemplate> receiver = Handle<FunctionTemplate>());
private:
Signature();
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698