Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 8481017: Merge 107820 - [Sync] Ensure new non-frontend datatypes release shared change processor (Closed)

Created:
9 years, 1 month ago by Nicolas Zea
Modified:
9 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Merge 107820 - [Sync] Ensure new non-frontend datatypes release shared change processor If we failed to startup, Stop() doesn't get called, so ensure we cleanup up properly in StartDoneImpl. BUG=102009 TEST=unit_tests Review URL: http://codereview.chromium.org/8341091 TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 3 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
9 years, 1 month ago (2011-11-04 23:55:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698