Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 8341091: [Sync] Ensure new non-frontend datatypes release shared change processor (Closed)

Created:
9 years, 1 month ago by Nicolas Zea
Modified:
9 years, 1 month ago
Reviewers:
GeorgeY, akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Ensure new non-frontend datatypes release shared change processor If we failed to startup, Stop() doesn't get called, so ensure we cleanup up properly in StartDoneImpl. BUG=102009 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107820

Patch Set 1 #

Patch Set 2 : fix diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 3 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
George as FYI, this should fix the unit tests issue you were running into. Fred ...
9 years, 1 month ago (2011-10-28 00:34:27 UTC) #1
GeorgeY
On 2011/10/28 00:34:27, nzea wrote: > George as FYI, this should fix the unit tests ...
9 years, 1 month ago (2011-10-28 18:03:36 UTC) #2
akalin
On 2011/10/28 18:03:36, GeorgeY wrote: > On 2011/10/28 00:34:27, nzea wrote: > > George as ...
9 years, 1 month ago (2011-10-28 21:20:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8341091/2001
9 years, 1 month ago (2011-10-28 21:33:16 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 23:21:44 UTC) #5
Change committed as 107820

Powered by Google App Engine
This is Rietveld 408576698