Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 848063002: Get rid of unnecessary explicit TearDown in OffDomainInclusionDetectorTest. (Closed)

Created:
5 years, 11 months ago by gab
Modified:
5 years, 11 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@#c3_ODID_async
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unnecessary explicit TearDown in OffDomainInclusionDetectorTest. Somehow the exact diff in this CL is what made patch set 4 land while patch set 3 was failing ASAN @ https://codereview.chromium.org/836963003... but re-investigated on Matt's request and now all bots are green without it... TBR=mattm BUG=412468 Committed: https://crrev.com/030eed4d29c60b337e1effeb49cff806a412f3c3 Cr-Commit-Position: refs/heads/master@{#312228}

Patch Set 1 : no reset, no RunUntilIdle #

Patch Set 2 : reset, no RunUntilIdle #

Patch Set 3 : get rid of teardown? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gab
TBR mattm: going to try to land this, we'll see... very weird that it passes ...
5 years, 11 months ago (2015-01-20 18:34:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848063002/40001
5 years, 11 months ago (2015-01-20 18:34:54 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-20 18:50:57 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 18:52:10 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/030eed4d29c60b337e1effeb49cff806a412f3c3
Cr-Commit-Position: refs/heads/master@{#312228}

Powered by Google App Engine
This is Rietveld 408576698