Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc

Issue 848063002: Get rid of unnecessary explicit TearDown in OffDomainInclusionDetectorTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@#c3_ODID_async
Patch Set: get rid of teardown? Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
index a1a0eb005638a3688af1de8e62381088aded4955..4860a455d611c97fbe729e022981f34870d918e9 100644
--- a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
@@ -106,14 +106,6 @@ class OffDomainInclusionDetectorTest
base::Unretained(this))));
}
- void TearDown() override {
- // The SafeBrowsingService held by the MockSafeBrowsingDatabaseManager in
- // |off_domain_inclusion_detector_| is deleted asynchronously and we thus
- // need to cleanup explicitly here or the test will leak.
- off_domain_inclusion_detector_.reset();
- base::RunLoop().RunUntilIdle();
- }
-
AnalysisEvent GetLastEventAndReset() {
const AnalysisEvent last_event = observed_analysis_event_;
observed_analysis_event_ = AnalysisEvent::NO_EVENT;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698