Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 847943002: net: Remove unused private fields (Closed)

Created:
5 years, 11 months ago by hashimoto
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove unused private fields This change is a follow-up for https://codereview.chromium.org/838203002/. BUG=447445 Committed: https://crrev.com/dae13b0cc587a171592520c7b0ed4689f4c0b21b Cr-Commit-Position: refs/heads/master@{#311625}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -62 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 4 chunks +9 lines, -15 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 4 chunks +0 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hashimoto
5 years, 11 months ago (2015-01-13 07:52:59 UTC) #4
hashimoto
5 years, 11 months ago (2015-01-13 07:58:59 UTC) #5
mmenke
LGTM!
5 years, 11 months ago (2015-01-14 16:13:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847943002/40001
5 years, 11 months ago (2015-01-15 04:25:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-15 04:28:55 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 04:29:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dae13b0cc587a171592520c7b0ed4689f4c0b21b
Cr-Commit-Position: refs/heads/master@{#311625}

Powered by Google App Engine
This is Rietveld 408576698