Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 847893002: Implemented explicit resizing from guestview. (Closed)

Created:
5 years, 11 months ago by paulmeyer
Modified:
5 years, 11 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented explicit resizing from guestview. A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ BUG=434226 Committed: https://crrev.com/681a4fc1d1ac77a17c69ba23fa6710a0e3aa206f Cr-Commit-Position: refs/heads/master@{#311286}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments. #

Total comments: 1

Patch Set 3 : Addressed comment. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed test; fixed small bug. #

Patch Set 6 : Another small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -89 lines) Patch
M chrome/renderer/resources/extensions/extension_options.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 1 2 1 chunk +25 lines, -12 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 2 3 5 chunks +23 lines, -8 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 6 chunks +61 lines, -27 lines 0 comments Download
M extensions/common/api/guest_view_internal.json View 3 chunks +14 lines, -7 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.h View 2 chunks +5 lines, -1 line 0 comments Download
M extensions/common/guest_view/guest_view_constants.cc View 2 chunks +5 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/guest_view.js View 3 chunks +9 lines, -9 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_container.js View 1 2 3 4 5 2 chunks +12 lines, -6 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
paulmeyer
+fsamuel@
5 years, 11 months ago (2015-01-12 23:09:03 UTC) #3
Fady Samuel
https://codereview.chromium.org/847893002/diff/20001/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/847893002/diff/20001/content/browser/renderer_host/render_widget_host_impl.cc#newcode608 content/browser/renderer_host/render_widget_host_impl.cc:608: old_resize_params_.reset(); To land this, you're going to need to ...
5 years, 11 months ago (2015-01-12 23:13:56 UTC) #4
Fady Samuel
https://codereview.chromium.org/847893002/diff/20001/extensions/renderer/resources/guest_view/web_view.js File extensions/renderer/resources/guest_view/web_view.js (right): https://codereview.chromium.org/847893002/diff/20001/extensions/renderer/resources/guest_view/web_view.js#newcode218 extensions/renderer/resources/guest_view/web_view.js:218: WebViewImpl.prototype.setSize = function(params) { This is fine for testing ...
5 years, 11 months ago (2015-01-12 23:16:40 UTC) #5
paulmeyer
ptal https://codereview.chromium.org/847893002/diff/20001/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://codereview.chromium.org/847893002/diff/20001/content/browser/renderer_host/render_widget_host_impl.cc#newcode608 content/browser/renderer_host/render_widget_host_impl.cc:608: old_resize_params_.reset(); On 2015/01/12 23:13:56, Fady Samuel wrote: > ...
5 years, 11 months ago (2015-01-12 23:25:19 UTC) #6
Fady Samuel
lgtm + nit https://codereview.chromium.org/847893002/diff/40001/extensions/browser/api/guest_view/guest_view_internal_api.cc File extensions/browser/api/guest_view/guest_view_internal_api.cc (right): https://codereview.chromium.org/847893002/diff/40001/extensions/browser/api/guest_view/guest_view_internal_api.cc#newcode97 extensions/browser/api/guest_view/guest_view_internal_api.cc:97: extensions::SetSizeParams set_size_params; nit: Are we not ...
5 years, 11 months ago (2015-01-13 00:20:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847893002/60001
5 years, 11 months ago (2015-01-13 12:52:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/112989) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/48205) android_arm64_dbg_recipe ...
5 years, 11 months ago (2015-01-13 12:55:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847893002/80001
5 years, 11 months ago (2015-01-13 14:31:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/14293)
5 years, 11 months ago (2015-01-13 15:30:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847893002/100001
5 years, 11 months ago (2015-01-13 16:09:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847893002/120001
5 years, 11 months ago (2015-01-13 16:39:39 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 11 months ago (2015-01-13 17:45:42 UTC) #21
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/681a4fc1d1ac77a17c69ba23fa6710a0e3aa206f Cr-Commit-Position: refs/heads/master@{#311286}
5 years, 11 months ago (2015-01-13 17:47:19 UTC) #22
Zhenyao Mo
On 2015/01/13 17:47:19, I haz the power (commit-bot) wrote: > Patchset 6 (id:??) landed as ...
5 years, 11 months ago (2015-01-13 18:25:03 UTC) #23
Fady Samuel
5 years, 11 months ago (2015-01-14 00:53:23 UTC) #24
Message was sent while issue was closed. 
A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.chromium.org/800543005/ by fsamuel@chromium.org.

The reason for reverting is: Broke out of process PDF..

Powered by Google App Engine
This is Rietveld 408576698