Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: extensions/renderer/resources/guest_view/guest_view_container.js

Issue 847893002: Implemented explicit resizing from guestview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another small fix. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/guest_view_container.js
diff --git a/extensions/renderer/resources/guest_view/guest_view_container.js b/extensions/renderer/resources/guest_view/guest_view_container.js
index 876b60623de0658eda154e87ca06920835bbb73f..c53a34423eb0f8ef82283bed341982ffb83f44e8 100644
--- a/extensions/renderer/resources/guest_view/guest_view_container.js
+++ b/extensions/renderer/resources/guest_view/guest_view_container.js
@@ -81,14 +81,22 @@ GuestViewContainer.prototype.setupFocusPropagation = function() {
}.bind(this));
};
+GuestViewContainer.prototype.attach = function() {
+ // Augment the attach parameters with the element size, so that the guestview
+ // can fit the element initially.
+ var attachParams = this.buildAttachParams();
+ attachParams['elementWidth'] = parseInt(this.element.offsetWidth);
+ attachParams['elementHeight'] = parseInt(this.element.offsetHeight);
+
+ this.guest.attach(this.internalInstanceId, this.viewInstanceId, attachParams);
+};
+
GuestViewContainer.prototype.attachWindow = function() {
if (!this.internalInstanceId) {
return true;
}
- this.guest.attach(this.internalInstanceId,
- this.viewInstanceId,
- this.buildAttachParams());
+ this.attach();
return true;
};
@@ -101,9 +109,7 @@ GuestViewContainer.prototype.handleBrowserPluginAttributeMutation =
if (!this.guest.getId()) {
return;
}
- this.guest.attach(this.internalInstanceId,
- this.viewInstanceId,
- this.buildAttachParams());
+ this.attach();
}
};

Powered by Google App Engine
This is Rietveld 408576698