Source/bindings/core/v8/ScriptPreprocessor.cpp - Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPreprocessor.cpp

Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add ScriptSourceCode::isNull() comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptPreprocessor.cpp

diff --git a/Source/bindings/core/v8/ScriptPreprocessor.cpp b/Source/bindings/core/v8/ScriptPreprocessor.cpp

index 0df0d7aeb0a95fa2949bb9064fe01446f3e248f3..d167212ef2f4b3af05af35089166ffb71ac29a0f 100644

--- a/Source/bindings/core/v8/ScriptPreprocessor.cpp

+++ b/Source/bindings/core/v8/ScriptPreprocessor.cpp

@@ -54,7 +54,7 @@ ScriptPreprocessor::ScriptPreprocessor(v8::Isolate* isolate, const ScriptSourceC

ASSERT(frame);

v8::TryCatch tryCatch;

tryCatch.SetVerbose(true);

- Vector<ScriptSourceCode> sources;

+ WillBeHeapVector<ScriptSourceCode> sources;

sources.append(preprocessorSourceCode);

Vector<v8::Local<v8::Value> > scriptResults;

frame->script().executeScriptInIsolatedWorld(ScriptPreprocessorIsolatedWorldId, sources, DOMWrapperWorld::mainWorldExtensionGroup, &scriptResults);