Makefile - Issue 847753002: Merge v8_optimized_debug 1 and 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 847753002: Merge v8_optimized_debug 1 and 2 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index 6c2955126bdf3e99b9547336de388ac46bbd1fa4..cb7ad7136b74c79e446e436b3d487d81331429b9 100644

--- a/Makefile

+++ b/Makefile

@@ -110,7 +110,7 @@ ifeq ($(vtunejit), on)

endif

# optdebug=on

ifeq ($(optdebug), on)

Michael Achenbach 2015/01/12 08:55:42 Wonder if this is necessary. We have two modes alr

- GYPFLAGS += -Dv8_optimized_debug=2

+ GYPFLAGS += -Dv8_optimized_debug=1

endif

# unalignedaccess=on

ifeq ($(unalignedaccess), on)

@@ -430,7 +430,7 @@ $(OUT_MAKEFILES): $(GYPFILES) $(ENVFILE)

-Dv8_target_arch=$(V8_TARGET_ARCH) \

$(if $(findstring $(CXX_TARGET_ARCH),$(V8_TARGET_ARCH)), \

-Dtarget_arch=$(V8_TARGET_ARCH),) \

- $(if $(findstring optdebug,$@),-Dv8_optimized_debug=2,) \

+ $(if $(findstring optdebug,$@),-Dv8_optimized_debug=1,) \

Michael Achenbach 2015/01/12 08:55:42 nit: Can you maybe get rid of the tabs?

-S$(suffix $(basename $@))$(suffix $@) $(GYPFLAGS)

$(OUTDIR)/Makefile.native: $(GYPFILES) $(ENVFILE)

« no previous file with comments | « no previous file | build/standalone.gypi » ('j') | no next file with comments »