Merge v8_optimized_debug 1 and 2

Makefile

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 91 matching lines @@
   GYPFLAGS += -Dv8_enable_gdbjit=1
 endif
 ifeq ($(gdbjit), off)
   GYPFLAGS += -Dv8_enable_gdbjit=0
 endif
 # vtunejit=on
 ifeq ($(vtunejit), on)
   GYPFLAGS += -Dv8_enable_vtunejit=1
 endif
 # optdebug=on
 ifeq ($(optdebug), on)

[Michael Achenbach, 2015/01/12 08:55:42]

Wonder if this is necessary. We have two modes already, debug and optdebug in
the top-level Makefile that cover the two levels. I don't see a reason why one
would need this switch now. Delete?

-  GYPFLAGS += -Dv8_optimized_debug=2
+  GYPFLAGS += -Dv8_optimized_debug=1
 endif
 # unalignedaccess=on
 ifeq ($(unalignedaccess), on)
   GYPFLAGS += -Dv8_can_use_unaligned_accesses=true
 endif
 # randomseed=12345, disable random seed via randomseed=0
 ifdef randomseed
   GYPFLAGS += -Dv8_random_seed=$(randomseed)
 endif
 # soname_version=1.2.3
@@ skipping 299 matching lines @@
                 cut -f 2 -d " " | cut -f 1 -d "-" ))
         $(eval CXX_TARGET_ARCH:=$(subst aarch64,arm64,$(CXX_TARGET_ARCH)))
         $(eval V8_TARGET_ARCH:=$(subst .,,$(suffix $(basename $@))))
         PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build:$(PYTHONPATH):$(shell pwd)/build/gyp/pylib:$(PYTHONPATH)" \
         GYP_GENERATORS=make \
         build/gyp/gyp --generator-output="$(OUTDIR)" build/all.gyp \
                       -Ibuild/standalone.gypi --depth=. \
                       -Dv8_target_arch=$(V8_TARGET_ARCH) \
                       $(if $(findstring $(CXX_TARGET_ARCH),$(V8_TARGET_ARCH)), \
                       -Dtarget_arch=$(V8_TARGET_ARCH),) \
-                      $(if $(findstring optdebug,$@),-Dv8_optimized_debug=2,) \
+                      $(if $(findstring optdebug,$@),-Dv8_optimized_debug=1,) \

[Michael Achenbach, 2015/01/12 08:55:42]

nit: Can you maybe get rid of the tabs?

                       -S$(suffix $(basename $@))$(suffix $@) $(GYPFLAGS)
 
 $(OUTDIR)/Makefile.native: $(GYPFILES) $(ENVFILE)
         PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build:$(PYTHONPATH):$(shell pwd)/build/gyp/pylib:$(PYTHONPATH)" \
         GYP_GENERATORS=make \
         build/gyp/gyp --generator-output="$(OUTDIR)" build/all.gyp \
                       -Ibuild/standalone.gypi --depth=. -S.native $(GYPFLAGS)
 
 must-set-ANDROID_NDK_ROOT_OR_TOOLCHAIN:
 ifndef ANDROID_NDK_ROOT
@@ skipping 62 matching lines @@
               third_party/icu --revision 277999 ; \
         fi
         svn checkout --force https://googletest.googlecode.com/svn/trunk \
             testing/gtest --revision 692
         svn checkout --force https://googlemock.googlecode.com/svn/trunk \
             testing/gmock --revision 485
 
 dependencies: builddeps
         # The spec is a copy of the hooks in v8's DEPS file.
         gclient sync -r fb782d4369d5ae04f17a2fceef7de5a63e50f07b --spec="solutions = [{u'managed': False, u'name': u'buildtools', u'url': u'https://chromium.googlesource.com/chromium/buildtools.git', u'custom_deps': {}, u'custom_hooks': [{u'name': u'clang_format_win',u'pattern': u'.',u'action': [u'download_from_google_storage',u'--no_resume',u'--platform=win32',u'--no_auth',u'--bucket',u'chromium-clang-format',u'-s',u'buildtools/win/clang-format.exe.sha1']},{u'name': u'clang_format_mac',u'pattern': u'.',u'action': [u'download_from_google_storage',u'--no_resume',u'--platform=darwin',u'--no_auth',u'--bucket',u'chromium-clang-format',u'-s',u'buildtools/mac/clang-format.sha1']},{u'name': u'clang_format_linux',u'pattern': u'.',u'action': [u'download_from_google_storage',u'--no_resume',u'--platform=linux*',u'--no_auth',u'--bucket',u'chromium-clang-format',u'-s',u'buildtools/linux64/clang-format.sha1']}],u'deps_file': u'.DEPS.git', u'safesync_url': u''}]"