Move User Manager onto a System profile.

chrome/browser/profiles/profile.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class gathers state related to a single user profile.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_H_
 
 #include <string>
@@ skipping 301 matching lines @@
 
   // Returns the home page for this profile.
   virtual GURL GetHomePage() = 0;
 
   // Returns whether or not the profile was created by a version of Chrome
   // more recent (or equal to) the one specified.
   virtual bool WasCreatedByVersionOrLater(const std::string& version) = 0;
 
   std::string GetDebugName();
 
   // Returns whether it is a guest session.

[noms (inactive), 2015/01/20 13:43:17]

nit: Bleh, not a giant fan about how one is a guest "session", but the other is
a system "profile". Seems inconsistent.

[Mike Lerman, 2015/01/20 16:18:11]

Dy'arg, ok, I'll fix that in another CL. IsGuestSession() -> IsGuestProfile().

   virtual bool IsGuestSession() const;
 
+  // Returns whether it is a system profile.
+  virtual bool IsSystemProfile() const;
+
   // Did the user restore the last session? This is set by SessionRestore.
   void set_restored_last_session(bool restored_last_session) {
     restored_last_session_ = restored_last_session;
   }
   bool restored_last_session() const {
     return restored_last_session_;
   }
 
   // Sets the ExitType for the profile. This may be invoked multiple times
   // during shutdown; only the first such change (the transition from
@@ skipping 42 matching lines @@
 
   // Convenience method to retrieve the default zoom level for the default
   // storage partition.
   double GetDefaultZoomLevelForProfile();
 
  protected:
   void set_is_guest_profile(bool is_guest_profile) {
     is_guest_profile_ = is_guest_profile;
   }
 
+  void set_is_system_profile(bool is_system_profile) {
+    is_system_profile_ = is_system_profile;
+  }
+
  private:
   bool restored_last_session_;
 
   // Used to prevent the notification that this Profile is destroyed from
   // being sent twice.
   bool sent_destroyed_notification_;
 
   // Accessibility events will only be propagated when the pause
   // level is zero.  PauseAccessibilityEvents and ResumeAccessibilityEvents
   // increment and decrement the level, respectively, rather than set it to
   // true or false, so that calls can be nested.
   int accessibility_pause_level_;
 
   bool is_guest_profile_;
 
+  bool is_system_profile_;

[noms (inactive), 2015/01/20 13:43:17]

Please document what a system profile means, and when it should be used.

[Mike Lerman, 2015/01/20 16:18:11]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(Profile);
 };
 
 // The comparator for profile pointers as key in a map.
 struct ProfileCompare {
   bool operator()(Profile* a, Profile* b) const;
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_H_