Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 847703003: Refactor to move chrome_page_zoom functions to components/ui/zoom. (Closed)

Created:
5 years, 11 months ago by wjmaclean
Modified:
5 years, 11 months ago
CC:
aandrey+blink_chromium.org, arv+watch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, dcheng, devtools-reviews_chromium.org, Dmitry Titov, jennb, jianli, paulirish+reviews_chromium.org, pfeldman, tfarina, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor to move chrome_page_zoom functions to components/ui/zoom. This refactor will allow non-chrome builds to access the functionality formerly provided by chrome_page_zoom. BUG=none TBR=sky@chromium.org Committed: https://crrev.com/91ddc475b86c272db176e93b8522d11708b0353c Cr-Commit-Position: refs/heads/master@{#311719}

Patch Set 1 #

Patch Set 2 : Rebased to master@{#311479} #

Patch Set 3 : Fix build. #

Total comments: 6

Patch Set 4 : Move unittest. #

Patch Set 5 : Address suggestions. #

Patch Set 6 : Fix Mac compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -364 lines) Patch
M chrome/browser/browser_commands_unittest.cc View 7 chunks +6 lines, -6 lines 0 comments Download
D chrome/browser/chrome_page_zoom.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chrome_page_zoom.cc View 1 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/chrome_page_zoom_constants.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/chrome_page_zoom_constants.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/chrome_page_zoom_unittest.cc View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/host_zoom_map_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/viewport.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A components/ui/zoom/page_zoom.h View 1 chunk +46 lines, -0 lines 0 comments Download
A + components/ui/zoom/page_zoom.cc View 1 2 3 4 5 chunks +18 lines, -10 lines 0 comments Download
A components/ui/zoom/page_zoom_constants.h View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A + components/ui/zoom/page_zoom_constants.cc View 1 chunk +7 lines, -5 lines 0 comments Download
A + components/ui/zoom/page_zoom_unittests.cc View 1 2 3 3 chunks +12 lines, -11 lines 0 comments Download
M components/ui_zoom.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M pdf/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/instance.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M pdf/pdf.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
wjmaclean
Could you please give this a first-look? Most of the changes outside of components are ...
5 years, 11 months ago (2015-01-14 17:25:34 UTC) #2
wjmaclean
On 2015/01/14 17:25:34, wjmaclean wrote: > Could you please give this a first-look? Most of ...
5 years, 11 months ago (2015-01-14 17:26:29 UTC) #3
Fady Samuel
lgtm + nits https://codereview.chromium.org/847703003/diff/40001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (left): https://codereview.chromium.org/847703003/diff/40001/chrome/browser/ui/browser.cc#oldcode39 chrome/browser/ui/browser.cc:39: #include "chrome/browser/chrome_page_zoom.h" Where's the new include? ...
5 years, 11 months ago (2015-01-14 17:38:15 UTC) #4
wjmaclean
https://codereview.chromium.org/847703003/diff/40001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (left): https://codereview.chromium.org/847703003/diff/40001/chrome/browser/ui/browser.cc#oldcode39 chrome/browser/ui/browser.cc:39: #include "chrome/browser/chrome_page_zoom.h" On 2015/01/14 17:38:14, Fady Samuel wrote: > ...
5 years, 11 months ago (2015-01-14 17:56:49 UTC) #5
wjmaclean
gene@chromium.org: Please review changes in pdf/ blundell@chromium.org: Please review changes in components/
5 years, 11 months ago (2015-01-14 17:59:05 UTC) #7
jochen (gone - plz use gerrit)
components/ lgtm
5 years, 11 months ago (2015-01-15 15:02:25 UTC) #9
gene
lgtm for pdf
5 years, 11 months ago (2015-01-15 18:20:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847703003/90001
5 years, 11 months ago (2015-01-15 18:22:49 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 11 months ago (2015-01-15 19:58:59 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 20:01:07 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/91ddc475b86c272db176e93b8522d11708b0353c
Cr-Commit-Position: refs/heads/master@{#311719}

Powered by Google App Engine
This is Rietveld 408576698