chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm - Issue 847703003: Refactor to move chrome_page_zoom functions to components/ui/zoom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

Issue 847703003: Refactor to move chrome_page_zoom functions to components/ui/zoom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mac compile. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

index 60fbf5c2e2ea0606d24343f52378fd4f46de9e41..234eb6d92827d1b22738ade1fe3a7921cbfe6ddc 100644

--- a/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm

@@ -6,10 +6,10 @@

#include "base/mac/foundation_util.h"

#include "base/strings/string_number_conversions.h"

-#include "chrome/browser/chrome_page_zoom.h"

#import "chrome/browser/ui/cocoa/info_bubble_view.h"

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#include "chrome/grit/generated_resources.h"

+#include "components/ui/zoom/page_zoom.h"

#include "components/ui/zoom/zoom_controller.h"

#include "content/public/common/page_zoom.h"

#include "skia/ext/skia_utils_mac.h"

@@ -314,7 +314,7 @@ void SetZoomBubbleAutoCloseDelayForTesting(NSTimeInterval time_interval) {

// there haven't been associated crashes in the wild, so it seems

// fine in practice. It might make sense to close the bubble in

// that case, though.

- chrome_page_zoom::Zoom(webContents, alterPageZoom);

+ ui_zoom::PageZoom::Zoom(webContents, alterPageZoom);

}

@end

« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm » ('j') | no next file with comments »