Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 847413002: Revert of Disable NaClBrowserTestNewlib.Bad on Linux (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews, native-client-reviews_googlegroups.com, Nick Bray (chromium), Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable NaClBrowserTestNewlib.Bad on Linux (patchset #1 id:1 of https://codereview.chromium.org/851843002/) Reason for revert: I reverted the change that made this test flaky, so we can re-enable the test (see https://codereview.chromium.org/793723006). Original issue's description: > Disable NaClBrowserTestNewlib.Bad on Linux > > BUG=448596 > TBR=ncbray@chromium.org > CC=sbc@chromium.org,rch@chromium.org,teravest@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/6ebc820381ef4694c6bbef164c84181ec434ae3c TBR=ncbray@chromium.org,rockot@chromium.org NOTREECHECKS=true NOTRY=true BUG=448596 Committed: https://crrev.com/fb1af21386336e05c974993234ab0be9c17e3722 Cr-Commit-Position: refs/heads/master@{#311804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/test/nacl/nacl_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mark Seaborn
Created Revert of Disable NaClBrowserTestNewlib.Bad on Linux
5 years, 11 months ago (2015-01-15 00:06:23 UTC) #1
Mark Seaborn
Justin, can you review this, please? (I don't like to use TBR unnecessarily.)
5 years, 11 months ago (2015-01-15 00:07:26 UTC) #3
teravest
lgtm
5 years, 11 months ago (2015-01-15 00:10:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847413002/1
5 years, 11 months ago (2015-01-16 01:00:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 01:01:14 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb1af21386336e05c974993234ab0be9c17e3722 Cr-Commit-Position: refs/heads/master@{#311804}
5 years, 11 months ago (2015-01-16 01:02:01 UTC) #8
Mark Seaborn
5 years, 11 months ago (2015-01-16 01:15:08 UTC) #9
Message was sent while issue was closed.
Gah, I didn't mean to commit this with NOTREECHECKS=true, NOTRY=true and TBR. 
Frustrating that those are the defaults.

Powered by Google App Engine
This is Rietveld 408576698