Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 793723006: Revert of NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case (patchset #4 id:60001 of https://codereview.chromium.org/849523002/) Reason for revert: The change appears to cause NaClBrowserTestNewlib.Bad to become flaky. The flakiness was reported in: BUG=448596 Original change description: > NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case > > We can remove Plugin::NexeFileDidOpenContinuation(), which gets called > via the "init_done" SRPC call (which calls > StartupInitializationComplete() in plugin/service_runtime.cc). > > Its work gets done by the newer > ManifestServiceProxy::StartupInitializationComplete() in > components/nacl/renderer/ppb_nacl_private_impl.cc, which gets called > via Chrome IPC (by the "PpapiHostMsg_StartupInitializationComplete" > message). > > ppapi_dispatcher.cc: In order to keep the error handling tests in > NaClBrowserTestNewlib.Bad passing, send the > StartupInitializationComplete message earlier, before we call > PPP_InitializeModule(). This ensures that crashes in > PPP_InitializeModule() are reported properly. > > Note that PNaCl still relies on "init_done" for now. > > BUG=428030 > BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 > > Committed: https://crrev.com/4c03d4d0964b0b69f5741aac6c78557b415617e1 > Cr-Commit-Position: refs/heads/master@{#311298} BUG=428030 BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 Committed: https://crrev.com/ec66f0e4a143a1d87145e58258be1cc4d38c2f39 Cr-Commit-Position: refs/heads/master@{#311495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M ppapi/nacl_irt/ppapi_dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Mark Seaborn
Created Revert of NaCl: Remove reliance on "init_done" SRPC call in the non-PNaCl case
5 years, 11 months ago (2015-01-14 06:16:13 UTC) #1
Mark Seaborn
Please review/rubber-stamp -- I don't intend to TBR this. :-)
5 years, 11 months ago (2015-01-14 06:20:29 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-14 14:54:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793723006/1
5 years, 11 months ago (2015-01-14 15:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 16:56:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:56:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec66f0e4a143a1d87145e58258be1cc4d38c2f39
Cr-Commit-Position: refs/heads/master@{#311495}

Powered by Google App Engine
This is Rietveld 408576698