Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 847283004: Web Animations: Simplify mutable AnimationTimeline currentTime and playbackRate (Closed)

Created:
5 years, 11 months ago by dstockwell
Modified:
5 years, 11 months ago
Reviewers:
samli
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Simplify mutable AnimationTimeline currentTime and playbackRate This uses the same model as AnimationPlayer, treating zeroTime as the startTime of the timeline. This resolves some issues where the setter did not set a consistent value (see test) and ensures that with playbackRate 0, the currentTime is identical to the set value. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188428

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Invalidate compositor animations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
A LayoutTests/web-animations-api/animationtimeline-consistent.html View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 1 2 5 chunks +28 lines, -14 lines 0 comments Download
M Source/core/animation/AnimationTimelineTest.cpp View 6 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dstockwell
Ran into some issues and decided to overhaul this. I think this was complex previously ...
5 years, 11 months ago (2015-01-14 12:50:41 UTC) #2
dstockwell
https://codereview.chromium.org/847283004/diff/20001/LayoutTests/web-animations-api/animationtimeline-consistent.html File LayoutTests/web-animations-api/animationtimeline-consistent.html (right): https://codereview.chromium.org/847283004/diff/20001/LayoutTests/web-animations-api/animationtimeline-consistent.html#newcode14 LayoutTests/web-animations-api/animationtimeline-consistent.html:14: assert_approx_equals(document.timeline.currentTime, 100, 0.1); this was coming out ~75 for ...
5 years, 11 months ago (2015-01-14 12:55:40 UTC) #3
samli
lgtm
5 years, 11 months ago (2015-01-14 23:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847283004/40001
5 years, 11 months ago (2015-01-15 00:06:05 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 01:31:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188428

Powered by Google App Engine
This is Rietveld 408576698