Web Animations: Simplify mutable AnimationTimeline currentTime and playbackRate

Source/core/animation/AnimationTimeline.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 45 matching lines @@
 const double AnimationTimeline::s_minimumDelay = 0.04;
 
 
 PassRefPtrWillBeRawPtr<AnimationTimeline> AnimationTimeline::create(Document* document, PassOwnPtrWillBeRawPtr<PlatformTiming> timing)
 {
     return adoptRefWillBeNoop(new AnimationTimeline(document, timing));
 }
 
 AnimationTimeline::AnimationTimeline(Document* document, PassOwnPtrWillBeRawPtr<PlatformTiming> timing)
     : m_document(document)
-    , m_zeroTime(0)
-    , m_documentCurrentTimeSnapshot(0)
-    , m_zeroTimeOffset(0)
+    , m_zeroTime(0) // 0 is used by unit tests which cannot initialize from the loader
+    , m_zeroTimeInitialized(false)
     , m_playbackRate(1)
     , m_lastCurrentTimeInternal(0)
 {
     if (!timing)
         m_timing = adoptPtrWillBeNoop(new AnimationTimelineTiming(this));
     else
         m_timing = timing;
 
     ASSERT(document);
 }
@@ skipping 96 matching lines @@
 }
 
 void AnimationTimeline::AnimationTimelineTiming::trace(Visitor* visitor)
 {
     visitor->trace(m_timeline);
     AnimationTimeline::PlatformTiming::trace(visitor);
 }
 
 double AnimationTimeline::zeroTime()
 {
-    if (!m_zeroTime && m_document && m_document->loader()) {
+    if (!m_zeroTimeInitialized && m_document && m_document->loader()) {
         m_zeroTime = m_document->loader()->timing()->referenceMonotonicTime();
+        m_zeroTimeInitialized = true;
     }
-    return m_zeroTime + m_zeroTimeOffset;
+    return m_zeroTime;
 }
 
 double AnimationTimeline::currentTime(bool& isNull)
 {
     return currentTimeInternal(isNull) * 1000;
 }
 
 double AnimationTimeline::currentTimeInternal(bool& isNull)
 {
     if (!m_document) {
         isNull = true;
         return std::numeric_limits<double>::quiet_NaN();
     }
-    // New currentTime = currentTime when the playback rate was last changed + time delta since then * playback rate
-    double delta = document()->animationClock().currentTime() - m_documentCurrentTimeSnapshot;
-    double result = m_documentCurrentTimeSnapshot - zeroTime() + delta * playbackRate();
+    double result = m_playbackRate == 0
+        ? zeroTime()
+        : (document()->animationClock().currentTime() - zeroTime()) * m_playbackRate;
     isNull = std::isnan(result);
     return result;
 }
 
 double AnimationTimeline::currentTime()
 {
     return currentTimeInternal() * 1000;
 }
 
 double AnimationTimeline::currentTimeInternal()
 {
     bool isNull;
     return currentTimeInternal(isNull);
 }
 
 void AnimationTimeline::setCurrentTime(double currentTime)
 {
     setCurrentTimeInternal(currentTime / 1000);
 }
 
 void AnimationTimeline::setCurrentTimeInternal(double currentTime)
 {
-    m_zeroTimeOffset = document()->animationClock().currentTime() - m_zeroTime - currentTime;
+    m_zeroTime = m_playbackRate == 0
+        ? currentTime
+        : (document()->animationClock().currentTime() - currentTime) / m_playbackRate;
+    m_zeroTimeInitialized = true;
+
+    for (const auto& player : m_players) {
+        // The Player needs a timing update to pick up a new time.
+        player->setOutdated();
+        // Any corresponding compositor animation will need to be restarted. Marking the
+        // source changed forces this.
+        player->setCompositorPending(true);
+    }
 }
 
 double AnimationTimeline::effectiveTime()
 {
     double time = currentTimeInternal();
     return std::isnan(time) ? 0 : time;
 }
 
 void AnimationTimeline::pauseAnimationsForTesting(double pauseTime)
 {
@@ skipping 19 matching lines @@
 void AnimationTimeline::setOutdatedAnimationPlayer(AnimationPlayer* player)
 {
     ASSERT(player->outdated());
     m_playersNeedingUpdate.add(player);
     if (m_document && m_document->page() && !m_document->page()->animator().isServicingAnimations())
         m_timing->serviceOnNextFrame();
 }
 
 void AnimationTimeline::setPlaybackRate(double playbackRate)
 {
-    // FIXME: floating point error difference between current time before and after the playback rate changes
-    if (!m_documentCurrentTimeSnapshot)
-        m_documentCurrentTimeSnapshot = m_zeroTime;
-    m_zeroTimeOffset += (document()->animationClock().currentTime() - m_documentCurrentTimeSnapshot) * (1 - m_playbackRate);
-    m_documentCurrentTimeSnapshot = document()->animationClock().currentTime();
+    double currentTime = currentTimeInternal();
     m_playbackRate = playbackRate;
+    m_zeroTime = playbackRate == 0
+        ? currentTime
+        : document()->animationClock().currentTime() - currentTime / playbackRate;
+    m_zeroTimeInitialized = true;
+
     for (const auto& player : m_players) {
+        // Corresponding compositor animation may need to be restarted to pick up
+        // the new playback rate. Marking the source changed forces this.
         player->setCompositorPending(true);
     }
 }
 
 double AnimationTimeline::playbackRate() const
 {
     return m_playbackRate;
 }
 
 #if !ENABLE(OILPAN)
 void AnimationTimeline::detachFromDocument()
 {
     // FIXME: AnimationTimeline should keep Document alive.
     m_document = nullptr;
 }
 #endif
 
 void AnimationTimeline::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_document);
     visitor->trace(m_timing);
     visitor->trace(m_playersNeedingUpdate);
     visitor->trace(m_players);
 #endif
 }
 
 } // namespace