DescriptionRevert of Make the HTMLDocumentParser yield more aggressively (patchset #36 id:740001 of https://codereview.chromium.org/673603002/)
Reason for revert:
This might break DumpAccessibilityTreeTest.AccessibilityANoText on Android http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29
[ RUN ] DumpAccessibilityTreeTest.AccessibilityANoText
[WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
[ERROR:shell_android.cc(69)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): screen_orientation_lock_smoke.html
[ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
[WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
Testing: /storage/emulated/0/content/test/data/accessibility/html/a-no-text.html
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:202: Failure
Value of: is_different
Actual: true
Expected: false
[WARNING:channel.cc(136)] WriteMessage() while shutting down
[WARNING:channel.cc(136)] WriteMessage() while shutting down
* Line Expected
- ---- --------
1 android.webkit.WebView focusable focused scrollable
2 android.view.View
3 android.view.View clickable focusable name='dest1'
4 android.view.View clickable focusable name='dest2'
5 android.view.View clickable focusable name='dest3'
6 android.view.View clickable focusable name='dest4'
7 android.view.View clickable focusable name='dest5'
8 android.view.View clickable focusable name='dest6'
9 android.view.View clickable focusable name='dest7'
10 android.view.View clickable focusable name='dest.8'
* 11 android.view.View clickable focusable name='dest9'
* 12 android.view.View clickable focusable name='dest10'
13 <-- End-of-file -->
Actual
------
android.webkit.WebView focusable focused scrollable
android.view.View
android.view.View clickable focusable name='dest1'
android.view.View clickable focusable name='dest2'
android.view.View clickable focusable name='dest3'
android.view.View clickable focusable name='dest4'
android.view.View clickable focusable name='dest5'
android.view.View clickable focusable name='dest6'
android.view.View clickable focusable name='dest7'
android.view.View clickable focusable name='dest.8'
android.view.View clickable focusable name='greenbox'
android.view.View clickable focusable name='greenbox'
<-- End-of-file -->
[ FAILED ] DumpAccessibilityTreeTest.AccessibilityANoText, where TypeParam = and GetParam() = (601 ms)
[----------] 1 test from DumpAccessibilityTreeTest (604 ms total)
Original issue's description:
> Make the HTMLDocumentParser yield more aggressively
>
> Based on eseidel@'s CL: https://codereview.chromium.org/258013009/
>
> Before this CL,
> HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser
> parsed the received chunk inline.
> This was problematic because the function is invoked in IPC priority,
> and DOM construction can block other time critical tasks.
>
> This CL stops inline parsing and didReceiveParsedChunkFromBackgroundParser
> is changed to always defer the processing.
>
> Note that this also changes how HTMLPreloader is scheduled.
> Before this CL, the preloader was not invoked when pump was done inline
> from didReceiveParsedChunkFromBackgroundParser.
> However, this CL ensures that the preloader is always invoked for all
> confirmed tokens so that resource loading would not be delayed from
> running slow synchronous scripts. This CL also delays the preloader
> invocation until appcache is initialized, so that preloader requests would
> respect it.
>
> Rebaselines due to preloader being invoked more eagerly:
> inspector/tracing/timeline-script-tag-1.html
> fast/dom/HTMLLinkElement/link-and-subresource-test.html
> permissionclient/image-permissions.html
> tables/mozilla_expected_failures/bugs/bug128876.html
>
> BUG=356292, 421300
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188275
TBR=haraken@chromium.org,skyostil@google.com,tyoshino@chromium.org,kouhei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356292, 421300
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188308
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (2 generated)
|