Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 847043004: Require HPKP pins to be quoted. (Closed)

Created:
5 years, 11 months ago by davidben
Modified:
5 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require HPKP pins to be quoted. BUG=448439 Committed: https://crrev.com/3df97e6d1437a9199949455ee097f60ec20d72f8 Cr-Commit-Position: refs/heads/master@{#311366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M net/http/http_security_headers.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 3 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
5 years, 11 months ago (2015-01-13 21:30:55 UTC) #2
Ryan Sleevi
lgtm
5 years, 11 months ago (2015-01-13 21:32:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847043004/1
5 years, 11 months ago (2015-01-13 21:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 00:11:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:12:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3df97e6d1437a9199949455ee097f60ec20d72f8
Cr-Commit-Position: refs/heads/master@{#311366}

Powered by Google App Engine
This is Rietveld 408576698