Require HPKP pins to be quoted.

net/http/http_security_headers_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/sha1.h"
 #include "base/strings/string_piece.h"
 #include "crypto/sha2.h"
 #include "net/base/net_log.h"
 #include "net/base/test_completion_callback.h"
 #include "net/http/http_security_headers.h"
 #include "net/http/http_util.h"
 #include "net/http/transport_security_state.h"
 #include "net/ssl/ssl_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 HashValue GetTestHashValue(uint8 label, HashValueTag tag) {
   HashValue hash_value(tag);
   memset(hash_value.data(), label, hash_value.size());
   return hash_value;
 }
 
-std::string GetTestPin(uint8 label, HashValueTag tag) {
+std::string GetTestPinImpl(uint8 label, HashValueTag tag, bool quoted) {
   HashValue hash_value = GetTestHashValue(label, tag);
   std::string base64;
   base::Base64Encode(base::StringPiece(
       reinterpret_cast<char*>(hash_value.data()), hash_value.size()), &base64);
 
+  std::string ret;
   switch (hash_value.tag) {
     case HASH_VALUE_SHA1:
-      return std::string("pin-sha1=\"") + base64 + "\"";
+      ret = "pin-sha1=";
+      break;
     case HASH_VALUE_SHA256:
-      return std::string("pin-sha256=\"") + base64 + "\"";
+      ret = "pin-sha256=";
+      break;
     default:
       NOTREACHED() << "Unknown HashValueTag " << hash_value.tag;
       return std::string("ERROR");
   }
+  if (quoted)
+    ret += '\"';
+  ret += base64;
+  if (quoted)
+    ret += '\"';
+  return ret;
+}
+
+std::string GetTestPin(uint8 label, HashValueTag tag) {
+  return GetTestPinImpl(label, tag, true);
+}
+
+std::string GetTestPinUnquoted(uint8 label, HashValueTag tag) {
+  return GetTestPinImpl(label, tag, false);
 }
 
 };
 
 
 class HttpSecurityHeadersTest : public testing::Test {
 };
 
 
 TEST_F(HttpSecurityHeadersTest, BogusHeaders) {
@@ skipping 81 matching lines @@
   HashValueVector hashes;
   HashValueVector chain_hashes;
 
   // Set some fake "chain" hashes
   chain_hashes.push_back(GetTestHashValue(1, tag));
   chain_hashes.push_back(GetTestHashValue(2, tag));
   chain_hashes.push_back(GetTestHashValue(3, tag));
 
   // The good pin must be in the chain, the backup pin must not be
   std::string good_pin = GetTestPin(2, tag);
+  std::string good_pin_unquoted = GetTestPinUnquoted(2, tag);
   std::string backup_pin = GetTestPin(4, tag);
 
   EXPECT_FALSE(ParseHPKPHeader(std::string(), chain_hashes, &max_age,
                                &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("    ", chain_hashes, &max_age,
                                &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("abc", chain_hashes, &max_age,
                                &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("  abc", chain_hashes, &max_age,
                                &include_subdomains, &hashes));
@@ skipping 51 matching lines @@
                                &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("max-age=3488923;", chain_hashes, &max_age,
                                &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("max-age=3488923     e", chain_hashes,
                                &max_age, &include_subdomains, &hashes));
   EXPECT_FALSE(ParseHPKPHeader("max-age=3488923     includesubdomain",
                                chain_hashes, &max_age, &include_subdomains,
                                &hashes));
   EXPECT_FALSE(ParseHPKPHeader("max-age=34889.23", chain_hashes, &max_age,
                                &include_subdomains, &hashes));
+  EXPECT_FALSE(
+      ParseHPKPHeader("max-age=243; " + good_pin_unquoted + ";" + backup_pin,
+                      chain_hashes, &max_age, &include_subdomains, &hashes));
 
   // Check the out args were not updated by checking the default
   // values for its predictable fields.
   EXPECT_EQ(0, max_age.InSeconds());
   EXPECT_EQ(hashes.size(), (size_t)0);
 }
 
 TEST_F(HttpSecurityHeadersTest, ValidSTSHeaders) {
   base::TimeDelta max_age;
   base::TimeDelta expect_max_age;
@@ skipping 483 matching lines @@
   EXPECT_TRUE(state.ShouldUpgradeToSSL(domain));
   // The dynamic pins, which do not match |saved_hashes|, should take
   // precedence over the static pins and cause the check to fail.
   EXPECT_FALSE(state.CheckPublicKeyPins(domain,
                                         is_issued_by_known_root,
                                         saved_hashes,
                                         &failure_log));
 }
 
 };    // namespace net