Changes to android autofill preferences for wallet integration

Changes to android autofill preferences for wallet integration

Modeled after the Data Saver page. UI is preliminary. Full review from UX team and improvements to come.

BUG=446700
Committed: https://crrev.com/c8ec224f7690719a2ee414daf461f75458cc8d50
Cr-Commit-Position: refs/heads/master@{#311572}

[Evan Stade, 2015-01-13 20:11:03]

estade@chromium.org changed reviewers:
+ brettw@chromium.org, newt@chromium.org

[Evan Stade, 2015-01-13 20:11:20]

+newt for review
+brettw for fyi/optional review

[newt (away), 2015-01-14 02:04:53]

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
File chrome/android/java/res/xml/autofill_wallet_preferences.xml (right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
chrome/android/java/res/xml/autofill_wallet_preferences.xml:20: <!--
TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a
link.
I wouldn't change the behavior of HyperlinkPreference since it has the desired
behavior for the places where it's used. You could maybe rename it though.

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:466:
* @return Whether the Wallet import feature is enabled.
fix javadoc

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
(right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:60:
ChromeBasePreference walletPref =
can walletPref be managed by policy?

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:65:
if (!PersonalDataManager.isWalletImportFeatureAvailable())
curly braces. Also, I'd make this an if-else statement. No sense in setting the
summary of walletPref if you're just going to remove it.

[Evan Stade, 2015-01-14 22:26:43]

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
File chrome/android/java/res/xml/autofill_wallet_preferences.xml (right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
chrome/android/java/res/xml/autofill_wallet_preferences.xml:20: <!--
TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a
link.
On 2015/01/14 02:04:53, newt wrote:
> I wouldn't change the behavior of HyperlinkPreference since it has the desired
> behavior for the places where it's used. You could maybe rename it though.

Alright. I'd like to punt that to a later CL though.

If we rename it, would you recommend creating a new HyperlinkPreference class
that does what this and the data_reduction_learn_more want?

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:466:
* @return Whether the Wallet import feature is enabled.
On 2015/01/14 02:04:53, newt wrote:
> fix javadoc

Done.

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
(right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:60:
ChromeBasePreference walletPref =
On 2015/01/14 02:04:53, newt wrote:
> can walletPref be managed by policy?

Well, it doesn't exist yet, so this is an open question. Figuring that out is a
TODO.

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:65:
if (!PersonalDataManager.isWalletImportFeatureAvailable())
On 2015/01/14 02:04:53, newt wrote:
> curly braces. Also, I'd make this an if-else statement. No sense in setting
the
> summary of walletPref if you're just going to remove it.

Done.

[newt (away), 2015-01-14 22:54:13]

lgtm

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
File chrome/android/java/res/xml/autofill_wallet_preferences.xml (right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
chrome/android/java/res/xml/autofill_wallet_preferences.xml:20: <!--
TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a
link.
On 2015/01/14 22:26:43, Evan Stade wrote:
> On 2015/01/14 02:04:53, newt wrote:
> > I wouldn't change the behavior of HyperlinkPreference since it has the
desired
> > behavior for the places where it's used. You could maybe rename it though.
> 
> Alright. I'd like to punt that to a later CL though.
> 
> If we rename it, would you recommend creating a new HyperlinkPreference class
> that does what this and the data_reduction_learn_more want?

How does the Data Saver "Learn more" link look different from the link you're
adding here? The blue text color?

We could add an attribute to HyperlinkPreference to enable blue text.

[Evan Stade, 2015-01-14 23:10:27]

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
File chrome/android/java/res/xml/autofill_wallet_preferences.xml (right):

https://codereview.chromium.org/847023002/diff/20001/chrome/android/java/res/...
chrome/android/java/res/xml/autofill_wallet_preferences.xml:20: <!--
TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a
link.
> How does the Data Saver "Learn more" link look different from the link you're
> adding here? The blue text color?

yea, it's blue. But also, when you tap it, there's no row highlight.

It's unintuitive that two UI controls that do the same thing would look
different. But I guess it makes some sense that the appearance of a control
depends on its surroundings. That seems to be the distinction in desktop
settings between link-looking things that open subdialogs (e.g. "Manage
passwords") and buttons that open subdialogs (like "Content settings..."). We
use the link looking thing for controls that are inline with text, and the
button thing for standalone controls.

[Evan Stade, 2015-01-14 23:10:49]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-14 23:11:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/847023002/40001

[commit-bot: I haz the power, 2015-01-14 23:39:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-14 23:40:17]

Patchset 3 (id:??) landed as
https://crrev.com/c8ec224f7690719a2ee414daf461f75458cc8d50
Cr-Commit-Position: refs/heads/master@{#311572}