chrome/android/java/res/xml/autofill_wallet_preferences.xml - Issue 847023002: Changes to android autofill preferences for wallet integration

Side by Side Diff: chrome/android/java/res/xml/autofill_wallet_preferences.xml

Issue 847023002: Changes to android autofill preferences for wallet integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: its own page Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/xml/autofill_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2015 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8

	9 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"

	10 xmlns:app="http://schemas.android.com/apk/res-auto" >

	11

	12 <org.chromium.chrome.browser.preferences.ChromeSwitchPreference

	13 android:key="autofill_wallet_switch"

	14 android:summaryOn="@string/text_on"

	15 android:summaryOff="@string/text_off" />

	16

	17 <org.chromium.chrome.browser.preferences.TextMessagePreference

	18 android:title="@string/autofill_wallet_description" />

	19

	20 <!-- TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a link.
	newt (away) 2015/01/14 02:04:53 I wouldn't change the behavior of HyperlinkPrefere I wouldn't change the behavior of HyperlinkPreference since it has the desired behavior for the places where it's used. You could maybe rename it though. Evan Stade 2015/01/14 22:26:43 Alright. I'd like to punt that to a later CL thoug Show quoted text On 2015/01/14 02:04:53, newt wrote: > I wouldn't change the behavior of HyperlinkPreference since it has the desired > behavior for the places where it's used. You could maybe rename it though. Alright. I'd like to punt that to a later CL though. If we rename it, would you recommend creating a new HyperlinkPreference class that does what this and the data_reduction_learn_more want? newt (away) 2015/01/14 22:54:13 How does the Data Saver "Learn more" link look dif Show quoted text On 2015/01/14 22:26:43, Evan Stade wrote: > On 2015/01/14 02:04:53, newt wrote: > > I wouldn't change the behavior of HyperlinkPreference since it has the desired > > behavior for the places where it's used. You could maybe rename it though. > > Alright. I'd like to punt that to a later CL though. > > If we rename it, would you recommend creating a new HyperlinkPreference class > that does what this and the data_reduction_learn_more want? How does the Data Saver "Learn more" link look different from the link you're adding here? The blue text color? We could add an attribute to HyperlinkPreference to enable blue text. Evan Stade 2015/01/14 23:10:27 yea, it's blue. But also, when you tap it, there's Show quoted text > How does the Data Saver "Learn more" link look different from the link you're > adding here? The blue text color? yea, it's blue. But also, when you tap it, there's no row highlight. It's unintuitive that two UI controls that do the same thing would look different. But I guess it makes some sense that the appearance of a control depends on its surroundings. That seems to be the distinction in desktop settings between link-looking things that open subdialogs (e.g. "Manage passwords") and buttons that open subdialogs (like "Content settings..."). We use the link looking thing for controls that are inline with text, and the button thing for standalone controls.
	21 We should either fix HyperlinkPreference or copy the technique used by

	22 data_reduction_learn_more. -->

	23 <org.chromium.chrome.browser.preferences.HyperlinkPreference

	24 android:title="@string/autofill_wallet_management_link_text"

	25 app:url="@string/autofill_manage_wallet_cards_url" />

	26

	27 <org.chromium.chrome.browser.preferences.TextMessagePreference

	28 android:title="@string/autofill_wallet_cache_explanation" />

	29

	30 <org.chromium.chrome.browser.preferences.ButtonPreference

	31 android:key="autofill_clear_unmasked_cards"

	32 android:title="@string/autofill_wallet_clear_unmasked_cards" />

	33

	34 </PreferenceScreen>

OLD	NEW