Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 84693008: Improve HTMLInputElement exception messages. (Closed)

Created:
7 years ago by Mike West
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Improve HTMLInputElement exception messages. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -183 lines) Patch
M LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLInputElement/input-size-attribute-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/date/date-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/date/input-valueasnumber-date.html View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/date/input-valueasnumber-date-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/file/file-setrangetext-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/file/input-file-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/hidden/hidden-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/image/image-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-maxlength.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-maxlength-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/month/input-valueasnumber-month.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/month/input-valueasnumber-month-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/month/month-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-size.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-size-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-valueasnumber.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/number/number-valueasnumber-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/range/input-valueasnumber-range.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/range/input-valueasnumber-range-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/range/range-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/selection-wrongtype-expected.txt View 1 chunk +54 lines, -54 lines 0 comments Download
M LayoutTests/fast/forms/setrangetext-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/time/time-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time/time-valueasnumber.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/time/time-valueasnumber-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/week/input-valueasnumber-week.html View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/week/input-valueasnumber-week-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/week/week-setrangetext-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 15 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kenneth.r.christiansen
lgtm
7 years ago (2013-11-25 10:58:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/84693008/1
7 years ago (2013-11-25 11:03:08 UTC) #2
commit-bot: I haz the power
7 years ago (2013-11-25 12:40:48 UTC) #3
Message was sent while issue was closed.
Change committed as 162620

Powered by Google App Engine
This is Rietveld 408576698