Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 846913003: Don't show shortcut arrow on hosted apps on ChromeOS. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show shortcut arrow on hosted apps on ChromeOS. These were being shown if the new bookmark apps flow is enabled. BUG=450092 Committed: https://crrev.com/16a954c84064d644f9c05ed2ddcb7c3e25bac047 Cr-Commit-Position: refs/heads/master@{#312656}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/ui/app_list/extension_app_item.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
benwells
5 years, 11 months ago (2015-01-22 06:30:44 UTC) #2
Matt Giuca
lgtm https://codereview.chromium.org/846913003/diff/1/chrome/browser/ui/app_list/extension_app_item.cc File chrome/browser/ui/app_list/extension_app_item.cc (right): https://codereview.chromium.org/846913003/diff/1/chrome/browser/ui/app_list/extension_app_item.cc#newcode151 chrome/browser/ui/app_list/extension_app_item.cc:151: #endif nit: Blank line after this. https://codereview.chromium.org/846913003/diff/1/chrome/browser/ui/app_list/extension_app_item.cc#newcode153 chrome/browser/ui/app_list/extension_app_item.cc:153: ...
5 years, 11 months ago (2015-01-22 06:39:54 UTC) #3
benwells
https://codereview.chromium.org/846913003/diff/1/chrome/browser/ui/app_list/extension_app_item.cc File chrome/browser/ui/app_list/extension_app_item.cc (right): https://codereview.chromium.org/846913003/diff/1/chrome/browser/ui/app_list/extension_app_item.cc#newcode151 chrome/browser/ui/app_list/extension_app_item.cc:151: #endif On 2015/01/22 06:39:54, Matt Giuca wrote: > nit: ...
5 years, 11 months ago (2015-01-22 07:03:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846913003/20001
5 years, 11 months ago (2015-01-22 07:03:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846913003/20001
5 years, 11 months ago (2015-01-22 19:44:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 19:46:59 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 19:49:00 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/16a954c84064d644f9c05ed2ddcb7c3e25bac047
Cr-Commit-Position: refs/heads/master@{#312656}

Powered by Google App Engine
This is Rietveld 408576698