Don't show shortcut arrow on hosted apps on ChromeOS.

chrome/browser/ui/app_list/extension_app_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_item.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/launch_util.h"
@@ skipping 127 matching lines @@
   }
   GetAppSorting(profile_)->EnsureValidOrdinals(extension_id_,
                                                syncer::StringOrdinal());
   UpdatePositionFromExtensionOrdering();
 }
 
 ExtensionAppItem::~ExtensionAppItem() {
 }
 
 bool ExtensionAppItem::NeedsOverlay() const {
+#if defined(OS_CHROMEOS)
+  // The overlay is disabled completely in ChromeOS.
+  return false;
+#endif

[Matt Giuca, 2015/01/22 06:39:54]

nit: Blank line after this.

[benwells, 2015/01/22 07:03:23]

Done.

   // The overlay icon is disabled for hosted apps in windowed mode with
   // streamlined hosted apps.

[Matt Giuca, 2015/01/22 06:39:54]

Move this comment to just above the return.

[benwells, 2015/01/22 07:03:23]

Done.

-  bool streamlined_hosted_apps =
-      extensions::util::IsStreamlinedHostedAppsEnabled();
-#if defined(OS_CHROMEOS)
-  if (!streamlined_hosted_apps)
-    return false;
-#endif
   extensions::LaunchType launch_type =
       GetExtension()
           ? extensions::GetLaunchType(extensions::ExtensionPrefs::Get(profile_),
                                       GetExtension())
           : extensions::LAUNCH_TYPE_WINDOW;
 
   return !is_platform_app_ && extension_id_ != extension_misc::kChromeAppId &&
-      (!streamlined_hosted_apps ||
+      (!extensions::util::IsStreamlinedHostedAppsEnabled() ||
        launch_type != extensions::LAUNCH_TYPE_WINDOW);
 }
 
 void ExtensionAppItem::Reload() {
   const Extension* extension = GetExtension();
   bool is_installing = !extension;
   SetIsInstalling(is_installing);
   if (is_installing) {
     SetName(extension_name_);
     UpdateIcon();
@@ skipping 181 matching lines @@
   const syncer::StringOrdinal& launch =
      GetAppSorting(profile_)->GetAppLaunchOrdinal(extension_id_);
   set_position(syncer::StringOrdinal(
       page.ToInternalValue() + launch.ToInternalValue()));
 }
 
 AppListControllerDelegate* ExtensionAppItem::GetController() {
   return AppListService::Get(chrome::GetActiveDesktop())->
       GetControllerDelegate();
 }