Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 846833002: Make Roboto accessible from chrome://resources (Closed)

Created:
5 years, 11 months ago by Alexandre Carlton
Modified:
5 years, 11 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Roboto accessible from chrome://resources The Roboto font needs to be used for the Chrome PDF plugin (and will potentially need more users going forward). This change makes it accessible through chrome://resources (web UI) so that it is more broadly available. BUG=303491 Committed: https://crrev.com/ce9731da2f4dc43fd1e405ae27086118d6a859fc Cr-Commit-Position: refs/heads/master@{#311586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/contextual_search/promo.css View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/resources/roboto/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/roboto/roboto.woff View Binary file 0 comments Download
D chrome/browser/resources/roboto/roboto.woff2 View Binary file 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.cc View 2 chunks +0 lines, -6 lines 0 comments Download
A + ui/webui/resources/roboto/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/roboto/roboto.woff View Binary file 0 comments Download
A + ui/webui/resources/roboto/roboto.woff2 View Binary file 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Alexandre Carlton
5 years, 11 months ago (2015-01-12 01:42:03 UTC) #2
raymes
lgtm
5 years, 11 months ago (2015-01-12 01:48:03 UTC) #3
Alexandre Carlton
PTAL
5 years, 11 months ago (2015-01-12 01:49:06 UTC) #5
Mathieu
On 2015/01/12 01:49:06, Alexandre Carlton wrote: > PTAL Hello Alexandre, Thanks for doing this. Did ...
5 years, 11 months ago (2015-01-12 13:53:15 UTC) #6
Alexandre Carlton
On 2015/01/12 13:53:15, Mathieu Perreault wrote: > On 2015/01/12 01:49:06, Alexandre Carlton wrote: > > ...
5 years, 11 months ago (2015-01-12 22:46:18 UTC) #7
Mathieu
On 2015/01/12 22:46:18, Alexandre Carlton wrote: > On 2015/01/12 13:53:15, Mathieu Perreault wrote: > > ...
5 years, 11 months ago (2015-01-13 21:00:18 UTC) #8
Mathieu
On 2015/01/13 21:00:18, Mathieu Perreault wrote: > On 2015/01/12 22:46:18, Alexandre Carlton wrote: > > ...
5 years, 11 months ago (2015-01-13 22:01:27 UTC) #9
Alexandre Carlton
thestig@chromium.org: Please review changes in chrome/browser/browser_resources.grd estade@chromium.org: Please review changes in ui/webui/resources/*
5 years, 11 months ago (2015-01-14 00:23:51 UTC) #11
Lei Zhang
On 2015/01/14 00:23:51, Alexandre Carlton wrote: > mailto:thestig@chromium.org: Please review changes in > chrome/browser/browser_resources.grd lgtm
5 years, 11 months ago (2015-01-14 00:27:47 UTC) #12
Evan Stade
lgtm
5 years, 11 months ago (2015-01-14 22:36:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846833002/1
5 years, 11 months ago (2015-01-14 22:42:10 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 00:27:57 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:28:48 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce9731da2f4dc43fd1e405ae27086118d6a859fc
Cr-Commit-Position: refs/heads/master@{#311586}

Powered by Google App Engine
This is Rietveld 408576698