Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 846633002: Don't constrain the size of the cue root (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
aberent, philipj_slow
CC:
blink-reviews, ed+blinkwatch_opera.com, nessy, blink-reviews-css, gasubic, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, vcarbune.chromium, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't constrain the size of the cue root Since the 'text track container' is enclosed by the overlay enclosure, it is affected by the max-width in the matching UA style rule. This means that the cue root can never be wider than 800px. Remove the 'max-width' property from this rule entirely. The only other side-effect from this is that the cast button (when visible) will now be positioned at <5%,5%> within the <video> content rectangle. BUG=447161 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
A LayoutTests/media/track/track-cue-rendering-wider-than-controls.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/media/track/track-cue-rendering-wider-than-controls-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/mediaControls.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
This has the side-effect that the overlay cast button is moved to the "actual" corner ...
5 years, 11 months ago (2015-01-09 14:36:09 UTC) #2
philipj_slow
LGTM, this looks like a copy-paste issue originally, not sure why max-width would make sense ...
5 years, 11 months ago (2015-01-09 14:47:26 UTC) #3
fs
On 2015/01/09 14:47:26, philipj wrote: > ..., this looks like a copy-paste issue originally, not ...
5 years, 11 months ago (2015-01-09 15:10:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846633002/1
5 years, 11 months ago (2015-01-09 18:08:10 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 18:11:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188163

Powered by Google App Engine
This is Rietveld 408576698